-
Notifications
You must be signed in to change notification settings - Fork 74
Bump dependencies #2536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump dependencies #2536
Conversation
cc4870e to
a68eb2d
Compare
b8e2922 to
ac99552
Compare
|
Currently this is blocked because I upgraded CI to use go1.25 which ran into this issue: golang/go#74462 We can see the issue show up in CI here: https://ci.pinniped.broadcom.net/teams/main/pipelines/dockerfile-builders/jobs/build-k8s-code-generator-1.30/builds/56#L689eb8de:602 |
ac99552 to
120b98b
Compare
|
Note that the maintainers of x/tools say that they will fix the issue in x/tools@v0.24.1 and x/tools@v0.25.1. They also say that the issue is only with x/tools v0.8.0 through v0.25.0. But we're using v0.34.0. |
|
Oh I see, the issue is not with Pinniped's production code, but is with building our codegen container image for Kube 1.30 - 1.33. These are trying to install tools which are using old versions of The first
It could also fail while running go install for The script also runs The script also runs I confirmed that:
It looks like according to the same comment that I linked to above, they might fix Golang itself for this issue, but not until 1.25.1 estimated to be released in September. One possible workaround would be for the CI script to clone the source code of these problematic projects locally, Another option might be to use older versions of Go only for those Kubernetes versions which don't build with Go 1.25. But that might impact the Another option would be to wait a few weeks to see if they decide to fix this in Go 1.25.1. |
120b98b to
4f879f4
Compare
4f879f4 to
301c717
Compare
|
Attempting a workaround for the above issue with old |
|
For some reason, Go 1.25.0 decides that it does not want to add the |
On my laptop, building this PR's branch, running Same experiment on a linux amd64 server, and I can see that it is using Still on the same linux server, trying the same experiment again but now using |
|
For some reason I also had to make this change to our CI script to get the integration tests to run with Go 1.25.0. Not sure why we never needed this change before. f8781b4...b65f533 |
Automatically bumped all go.mod direct dependencies and/or images in dockerfiles.