Skip to content

Conversation

@cfryanr
Copy link
Contributor

@cfryanr cfryanr commented Oct 24, 2025

This PR allows kube cert agent deployment's strategy type to be configured via the Concierge's static ConfigMap. The default is the old behavior, which is to leave it unspecified (which therefore uses the k8s default of "RollingUpdate"). If provided, we validate that the string provided in the ConfigMap is one of the two strings currently allowed in the k8s Deployment API.

The ConfigMap can be edited to use the new setting like this:

apiVersion: v1
kind: ConfigMap
metadata:
  name: pinniped-concierge-config
  namespace: concierge
data:
  pinniped.yaml: |
    # Other top-level settings trimmed for brevity.
    kubeCertAgent:
      # This is the new setting. It can be "Recreate", "RollingUpdate", or null.
      # When this setting is missing, then it is null.
      deploymentStrategyType: Recreate
      # Other kubeCertAgent settings trimmed for brevity.

Release note:

Yes, TBD.

@netlify
Copy link

netlify bot commented Oct 24, 2025

Deploy Preview for pinniped-dev canceled.

Name Link
🔨 Latest commit fa5f754
🔍 Latest deploy log https://app.netlify.com/projects/pinniped-dev/deploys/68fbb058806b580008c2bfb8

@cfryanr cfryanr force-pushed the configurable_kube_cert_agent_strategy_type branch from f920b76 to 9be6bb0 Compare October 24, 2025 01:10
@cfryanr cfryanr enabled auto-merge October 24, 2025 17:01
@cfryanr cfryanr merged commit 2cfa610 into main Oct 27, 2025
36 checks passed
@cfryanr cfryanr deleted the configurable_kube_cert_agent_strategy_type branch October 27, 2025 16:24
@cfryanr cfryanr mentioned this pull request Oct 28, 2025
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants