Test 12-01-Delete doesn't remove the VCH certs directory

[anchal-agrawal]

Seen in https://ci.vcna.io/vmware/vic/16168. The Suggest resources - Invalid datacenter test in Group6-VIC-Machine.6-05-Create-Validation failed because of a VCH name collision with a previous VCH (from test Group12-VCH-BC.12-01-Delete) whose certs dir was not cleaned up.

I think this is due to

vic/tests/test-cases/Group12-VCH-BC/12-01-Delete.robot

Line 58 in 19c47c4

${ret}= Run bin/vic-machine-linux delete --target %{TEST_URL} --user %{TEST_USERNAME} --password=%{TEST_PASSWORD} --compute-resource=%{TEST_RESOURCE} --name %{VCH-NAME} --force

The test doesn't cleanup the certs directory after deleting the VCH. Also, it deletes the VCH directly instead of using the Cleanup VIC Appliance On Test Server or a similar secret keyword that redacts the username and password.

Acceptance criteria:

• Test cleans up the certs dir
• Test uses a secret keyword to delete the VCH

[zjs]

It seems like the cleanup of old certificate directories is supposed to happen as a part of Set Test Environment Variables:

vic/tests/resources/VCH-Util.robot

Lines 76 to 77 in 19c47c4

	# cleanup any potential old certs directories
	Remove Directory %{VCH-NAME} recursive=${true}

This keyword is called from the Suggest resources - Invalid datacenter test in Group6-VIC-Machine.6-05-Create-Validation:

vic/tests/test-cases/Group6-VIC-Machine/6-05-Create-Validation.robot

Line 24 in 19c47c4

Set Test Environment Variables

However, a few lines later in the test, the VCH name is changed:

vic/tests/test-cases/Group6-VIC-Machine/6-05-Create-Validation.robot

Lines 24 to 28 in 19c47c4

	Set Test Environment Variables
	# Attempt to cleanup old/canceled tests
	Run Keyword And Ignore Error Cleanup Dangling VMs On Test Server
	Run Keyword And Ignore Error Cleanup Datastore On Test Server
	Set Test VCH Name

Calling Set Test Environment Variables and then calling Set Test VCH Name seems to be a recurring pattern for tests in this suite. However, Set Test VCH Name is already called as a part of Set Test Environment Variables:

vic/tests/resources/VCH-Util.robot

Line 75 in 19c47c4

Set Test VCH Name

This suggests that one way to avoid failures due to re-use of the certificates directory would be to remove the explicit calls to Set Test VCH Name.

The deletion test failing to use a secret keyword that redacts credentials seems to be a separate issue, which we can also fix.