Merged
Conversation
mlh78750
reviewed
Nov 11, 2016
cmd/vic-machine/delete/delete.go
Outdated
| return errors.New("delete failed") | ||
| } | ||
|
|
||
| log.Warnf("VCH version %q is different with installer version %s. Force delete will try best to delete everything found.", vchConfig.Version.ShortVersion(), installerBuild.ShortVersion()) |
Contributor
There was a problem hiding this comment.
Change warning text to: Force delete will attempt to remove everything related to the installed VCH.
andrewtchin
reviewed
Nov 11, 2016
cmd/vic-machine/delete/delete.go
Outdated
| installerBuild := version.GetBuild() | ||
| if vchConfig.Version == nil || !installerBuild.Equal(vchConfig.Version) { | ||
| if !d.Data.Force { | ||
| log.Errorf("VCH version %q is different with installer version %s. Specify --force to force delete", vchConfig.Version.ShortVersion(), installerBuild.ShortVersion()) |
Contributor
There was a problem hiding this comment.
different than installer version
andrewtchin
reviewed
Nov 11, 2016
cmd/vic-machine/delete/delete.go
Outdated
| return errors.New("delete failed") | ||
| } | ||
|
|
||
| log.Warnf("VCH version %q is different with installer version %s. Force delete will attempt to remove everything related to the installed VCH", vchConfig.Version.ShortVersion(), installerBuild.ShortVersion()) |
andrewtchin
reviewed
Nov 11, 2016
lib/install/management/delete.go
Outdated
| err = errors.Errorf("Cannot find compute resources from configuration") | ||
| return nil, err | ||
| } | ||
| log.Warnf("Cannot find compute resources from configuration, try to delete under parent resource pool") |
andrewtchin
reviewed
Nov 11, 2016
lib/install/management/delete.go
Outdated
| err = errors.Errorf("Cannot find image stores from configuration") | ||
| return nil, err | ||
| } | ||
| log.Warnf("Cannot find image stores from configuration, try to delete from vm datastore") |
Contributor
|
lgtm |
| rp := compute.NewResourcePool(d.ctx, d.session, rpRef) | ||
|
|
||
| if d.parentResourcepool == nil { | ||
| log.Warnf("Do not find parent VCH resource pool") |
Contributor
There was a problem hiding this comment.
Minor - "Did not find..."
| Log ${output} | ||
| Should Be Equal As Integers ${rc} 0 | ||
| Should Not Contain ${output} Error | ||
| ${name}= Generate Random String 15 |
Contributor
|
LGTM |
Contributor
Author
|
. |
fdawg4l
pushed a commit
to fdawg4l/vic
that referenced
this pull request
Nov 16, 2016
* Try to delete old vch * add vic-machine backward compatibility test * update message * comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2719
If vic-machine identified the vm is one VCH instance, will delete the container VMs and VCH instance itself. Even the guestinfo configuration is changed, and some of configuration cannot be identified.
The problem is that if there is custom image store, or volume store configured, but vic-machine cannot read those configuration back, those resources will not be cleaned up.