[skip ci] Update vsan test bed to include DVS and DVPG#5842
Merged
mhagen-vmware merged 1 commit intomasterfrom Jul 26, 2017
Merged
[skip ci] Update vsan test bed to include DVS and DVPG#5842mhagen-vmware merged 1 commit intomasterfrom
mhagen-vmware merged 1 commit intomasterfrom
Conversation
mhagen-vmware
requested review from
mdharamadas1,
rajanashok,
rogeliosanchez and
singhshwetaQE
mhagen-vmware
force-pushed
the
feature/vsan-testbed
branch
from
12419d3 to
327ec42
Compare
rajanashok
approved these changes
Jul 26, 2017
Contributor
There was a problem hiding this comment.
lgtm
@mhagen-vmware This is cool. Just curious if this ruby file a dependency from nimbus that we need to keep up to date?
Contributor
Author
|
@rajanashok we might need to make some updates at some point, but they really should not make any fundamental changes like that, otherwise a ton of vsphere tests would then need to be updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #5540
We have constant problems with nimbus instability in govc, this pushes the network creation at least into the test bed so that we can need to make less govc calls.