[WIP] Implement API handler for VCH deletion [specific ci=Group23-VIC-Machine-Service]#6693
Closed
zjs wants to merge 20 commits intovmware:feature/vic-machine-servicefrom
Closed
[WIP] Implement API handler for VCH deletion [specific ci=Group23-VIC-Machine-Service]#6693zjs wants to merge 20 commits intovmware:feature/vic-machine-servicefrom
zjs wants to merge 20 commits intovmware:feature/vic-machine-servicefrom
Conversation
In "Implement tests for the VCH Creation API", a change was made to the way that the PUBLIC_NETWORK environment variable was quoted. This worked for robot test group 23, but broke several others. This commit reverts the global change and handles the quoting issue in a localized way.
zjs
force-pushed
the
topic/vic-machine-service-delete
branch
from
5497b57 to
de60cca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating a new PR, #6694, because this one is encountering a drone-related bug, and preserving this one in its current state in case that's useful for debugging drone.