[specific ci=1-11-Docker-RM] Force remove container in 1-11-Docker-RM test#6708
Merged
anchal-agrawal merged 1 commit intovmware:masterfrom Nov 8, 2017
Merged
Conversation
zjs
approved these changes
Nov 7, 2017
This commit makes the 'Remove a container and its anonymous volume' test case more robust by force-removing the container that runs the /bin/ls command, since it's possible for the container to not have powered off fully and the container state to not have updated to 'Stopped' before the remove command is issued in the test. Before this change, it was possible for the test to fail if the container state wasn't updated on time. This was seen in CI build 14551 for PR vmware#6665. Since that test snippet's intent (verify that the anonymous volume can be used by a new container) is unaffected by how the container is removed, this change is valid. Enhances vmware#6262
anchal-agrawal
force-pushed
the
6262-test-update
branch
from
923ad48 to
f47f000
Compare
AngieCris
pushed a commit
to AngieCris/vic
that referenced
this pull request
Nov 20, 2017
This commit makes the 'Remove a container and its anonymous volume' test case more robust by force-removing the container that runs the /bin/ls command, since it's possible for the container to not have powered off fully and the container state to not have updated to 'Stopped' before the remove command is issued in the test. Before this change, it was possible for the test to fail if the container state wasn't updated on time. This was seen in CI build 14551 for PR vmware#6665. Since that test snippet's intent (verify that the anonymous volume can be used by a new container) is unaffected by how the container is removed, this change is valid. Enhances vmware#6262
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit makes the 'Remove a container and its anonymous volume'
test case more robust by force-removing the container that runs the
/bin/ls command, since it's possible for the container to not have
powered off fully and the container state to not have updated to
'Stopped' before the remove command is issued in the test.
Before this change, it was possible for the test to fail if the
container state wasn't updated on time. This was seen in CI build
14551 for PR #6665.
Since that test snippet's intent (verify that the anonymous volume
can be used by a new container) is unaffected by how the container
is removed, this change is valid.
Enhances #6262