Extract constants for magic values [specific ci=Group23-VIC-Machine-Service]#6718
Merged
mhagen-vmware merged 2 commits intovmware:masterfrom Nov 21, 2017
Merged
Extract constants for magic values [specific ci=Group23-VIC-Machine-Service]#6718mhagen-vmware merged 2 commits intovmware:masterfrom
mhagen-vmware merged 2 commits intovmware:masterfrom
Conversation
zjs
requested review from
AngieCris,
anchal-agrawal,
jzt and
mdharamadas1
and removed request for
jzt
zjs
added
area/api
zjs
force-pushed
the
topic/magic-values
branch
from
edc2f77 to
9dd1ba4
Compare
Contributor
|
These MUST go into This package is specifically for constant values that need to be shared across components - without duplicate declarations or transitive package imports. |
mdharamadas1
approved these changes
Nov 8, 2017
mdharamadas1
approved these changes
Nov 8, 2017
jzt
approved these changes
Nov 13, 2017
AngieCris
approved these changes
Nov 15, 2017
zjs
force-pushed
the
feature/vic-machine-service
branch
7 times, most recently
from
ad673c0 to
dc30dd0
Compare
zjs
force-pushed
the
topic/magic-values
branch
from
9dd1ba4 to
599d1e5
Compare
zjs
force-pushed
the
topic/magic-values
branch
from
599d1e5 to
39ed72f
Compare
Extract constants for several "magic values" identified during review of the merge commit for the VCH creation API feature branch.
zjs
force-pushed
the
topic/magic-values
branch
from
39ed72f to
3739c3d
Compare
zjs
changed the title
jzt
approved these changes
Nov 21, 2017
hickeng
approved these changes
Nov 21, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract constants for several "magic values" identified during review of the merge commit for the VCH creation API feature branch.
See also: #6665