Centralize time formatting in datastore log naming [specific ci=Group23-VIC-Machine-Service]#6818
Merged
zjs merged 2 commits intovmware:masterfrom Nov 21, 2017
Merged
Conversation
zjs
added
area/api
zjs
force-pushed
the
topic/log-name-timestamp
branch
2 times, most recently
from
bd393c4 to
4792260
Compare
zjs
changed the title
hickeng
approved these changes
Nov 21, 2017
AngieCris
approved these changes
Nov 21, 2017
zjs
force-pushed
the
topic/log-name-timestamp
branch
from
4792260 to
4edd7f9
Compare
Refactor VCHLogger to ensure that time formatting is handled in a single location, for consistency. Additionally, replace the time format string with a reference to the pre-defined constant. Lastly, de-duplicate other constants related to log file naming.
zjs
force-pushed
the
topic/log-name-timestamp
branch
from
328df94 to
ec85ce8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor
VCHLoggerto ensure that time formatting is handled in a single location, for consistency.Additionally, replace the time format string with a reference to the pre-defined constant.
Lastly, de-duplicate other information about log file naming.
(See also: #6665 (comment))