Specify host parameter to datastore download command#6875
Merged
mhagen-vmware merged 3 commits intomasterfrom Nov 30, 2017
Merged
Specify host parameter to datastore download command#6875mhagen-vmware merged 3 commits intomasterfrom
mhagen-vmware merged 3 commits intomasterfrom
Conversation
mhagen-vmware
requested review from
anchal-agrawal,
dougm,
hickeng,
matthewavery,
mdharamadas1 and
sgairo
mdharamadas1
approved these changes
Nov 30, 2017
sgairo
approved these changes
Nov 30, 2017
Member
|
Feel free to revert to the older version of govc, but that isn't the problem. You need to specify the |
mhagen-vmware
force-pushed
the
feature/longevity-govc
branch
from
2b04571 to
d3acd8f
Compare
mhagen-vmware
changed the title
hickeng
reviewed
Nov 30, 2017
tests/resources/VCH-Util.robot
Outdated
| Log ${out} | ||
| Remove File vic-admin-cookies | ||
| ${out}= Run govc datastore.download %{VCH-NAME}/vmware.log %{VCH-NAME}-vmware${name-suffix}.log | ||
| ${out}= Run govc datastore.download -host $(govc vm.info %{VCH-NAME} | grep Host: | awk '{print $2}') %{VCH-NAME}/vmware.log %{VCH-NAME}-vmware${name-suffix}.log |
Contributor
There was a problem hiding this comment.
There is a Get VM Host Name keyword.
Contributor
There was a problem hiding this comment.
And if not keyword then awk '/Host:/{print$2}' is more concise.
hickeng
approved these changes
Nov 30, 2017
dougm
approved these changes
Nov 30, 2017
mdharamadas1
pushed a commit
to mdharamadas1/vic
that referenced
this pull request
Dec 1, 2017
mdharamadas1
pushed a commit
to mdharamadas1/vic
that referenced
this pull request
Dec 2, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we combine the jenkins logs from both 6.0 longevity with 6.5 longevity, we see that the the problem began on Nov 20th between 9:50AM and 1:27PM and affects both systems seemingly equally. Which leads me to believe that something changed in our software at the same time as that is the common denominator. I went back to the VIC 1.2.1 build and continue to see the problem, which narrows it down to something outside of the engine code itself and we find this commit which happened on Nov 20th 1:10PM:
#6788
Reverting to govc 0.15 immediately seemed to fix the problem on longevity 6.5, the upgrade from govc 0.15 to 0.16 included what looks like close to 100 commits over the course of almost 6 months.