Do not force logout on validation failure#7101
Merged
hickeng merged 1 commit intovmware:masterfrom Jan 17, 2018
Merged
Conversation
hickeng
added
kind/defect
lcastellano
approved these changes
Jan 16, 2018
Contributor
|
LGTM
|
mhagen-vmware
pushed a commit
that referenced
this pull request
Jan 17, 2018
Removes an explicit logout on vicadmin validation failure. This was causing the vicadmin session to be invalidated immediately which prevents collection of log bundles. This was of particular annoyance when in an environment that does not have internet access as docker hub is always unavailable which results in an effectively useless vicadmin unless using client certificate based auth.
mhagen-vmware
added a commit
that referenced
this pull request
Jan 17, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes an explicit logout on vicadmin validation failure. This was causing the vicadmin session to be invalidated immediately which prevents collection of log bundles.
This was of particular annoyance when in an environment that does not have internet access as
docker hub is always unavailable which results in a completely useless vicadmin.
This does not have an explicit test as we do not have an existing test environment defined without internet access and I'm unwilling to write a test that actually breaks the environment in order to test the other validated elements. I have opened #7102 for expansion of testing to include isolated environments.
This was part of #6943 but has been pulled out for 1.3.1 inclusion.