Conversation
Codecov Report
@@ Coverage Diff @@
## master #7292 +/- ##
=========================================
Coverage ? 31.58%
=========================================
Files ? 277
Lines ? 41828
Branches ? 0
=========================================
Hits ? 13212
Misses ? 27455
Partials ? 1161Continue to review full report at Codecov.
|
anchal-agrawal
approved these changes
Feb 8, 2018
CONTRIBUTING.md
Outdated
| priority/p3 - Bugs that SHOULD be fixed by a given release, time permitting. | ||
|
|
||
| priority/p4 - Bugs that SHOULD be fixed in a future (to be determined) release. | ||
| - priority/p0 - An issue that is not a bug and is blocking meaningful testing. No feature should be p0. eg. builds are failing because the syslog server is |
Contributor
There was a problem hiding this comment.
We're missing something at the end of because the syslog server is
CONTRIBUTING.md
Outdated
| priority/p4 - Bugs that SHOULD be fixed in a future (to be determined) release. | ||
| - priority/p0 - An issue that is not a bug and is blocking meaningful testing. No feature should be p0. eg. builds are failing because the syslog server is | ||
| - priority/p1 - An issue or feature that is required for the next release, typically an anchor feature; a large feature that is the focus for the release and drives the release date. | ||
| - prority/p2 - An issue or feature that is desired for the next release, typically a pebble;, a feature that has been approved for inclusion but is not considered the anchor feature. |
Contributor
There was a problem hiding this comment.
Stray comma in pebble;,
jzt
approved these changes
Feb 8, 2018
mdubya66
requested review from
AngieCris,
andrewtchin,
cgtexmex,
gigawhitlocks,
hickeng,
jak-atx,
lcastellano,
matthewavery,
mdharamadas1,
mhagen-vmware,
sflxn,
sgairo and
zjs
zjs
reviewed
Feb 8, 2018
Member
There was a problem hiding this comment.
I'm not sure making anchor work P1 and pebble work P2 is the best solution.
I think it's in the right ballpark, but I think the purpose of the more granular priorities is to help people focus on the right work. For features, I think the three main categories are:
- Issues that are in the critical path for an anchor feature.
- Other work that we want to include in the release (e.g., other parts of anchor features, important parts of pebbles).
- Work we can include in the release (e.g., optional parts of anchor features and less important parts of pebbles).
I think this split is more useful because anchor features can be very large, spanning many issues, and this makes it easy to highlight the relative priority of those issues (vs. the current proposal, where they'd all be P1).
Format-wise, I think it'd be helpful to capture this as a table, instead of as two separate lists. We would have a row for each priority and three columns: the "headings" column (with the priorities), a column for bugs, and a column for non-bugs.
Contributor
Author
|
Anchor's drive the release. pebbles do not. Anchor's should not have extraneous work in them. Same for pebbles. I'll consider a table but given the definitions for bugs and features are different enough. |
andrewtchin
approved these changes
Feb 8, 2018
Contributor
Author
|
I think it would be ok to have pebbles use 2, 3 and 4 priorities however based on critical path and am open to cleaning up that verbage. But Anchors should be P1. |
Contributor
Author
|
/me goes and looks at how to do tables in .md |
Contributor
Author
|
@zjs let me know if i've addressed your comments |
AngieCris
approved these changes
Feb 9, 2018
zjs
approved these changes
Feb 9, 2018
sflxn
pushed a commit
that referenced
this pull request
Mar 1, 2018
* Dump dmesg if container rootfs blocks or fails mount (#7260) This is to enable bridging of the guest side state with the virtual hardware if we see issues such as disks not presenting on a pvscsi controller or a mount operation hanging. * updating priority definitions to include features (#7292) * Change default fellows for gandalf (#7310) * Avoid exposing test credentials in 12-01-Delete (#7306) To avoid exposing test credentials, use the established `Run VIC Machine Delete Command` keyword, which in turn calls a secret keyword. This changes the behavior of the test slightly: - It no longer checks for the absence of "delete failed" in output. - It will wait up to 30 seconds for the deletion to succeed. - It will clean up cert files at the end of the deletion. * Bug fix in API delete test: disable volume store cleanup (#7303) * Remove volume store cleanup before re-installing VIC appliance using existing volume stores * Cleanup dangling volume stores on test teardown * Add logging for image upload (#7296) * Reduce datastore searches during non-vSAN delete operations (#6951) * Optimize portlayer volume cache rebuild on startup (#7267) This commit modifies the portlayer volume cache's rebuildCache func to only process the volumes from the volume store that is currently being added to the cache. rebuildCache is invoked for every volume store during portlayer startup. Before this change, rebuildCache would process volumes from all volume stores in the cache every time a volume store was added. This led to unneeded extra computation which could slow down portlayer startup and overwhelm NFS endpoints if NFS volume stores are being used. Fixes #6991 * Added local ci testing target to makefile (#7170) Make testing locally as friction-free as possible by 1. Adding a makefile target 'local-ci-test' 2. Using TARGET_VCH added in VIC 1.3 to use an existing VCH 3. Using a custom script that doesn't utilize drone so that if the test fails and craters, we can still access the logs 4. Parameters can come from env vars, arguments, or secrets file Resolves #7162 * Added upload progress bar tracker for ISO images. (#7320) * Added upload progress bar tracker for ISO images. Removed concurrent upload since it doesn't make any significant performance imapact. When I tried to measure performance differene with and without concurrent uppload, the results were fluctuating in a wide range so no good measurement was possible. * Document the design for the vic-machine API (#6702) This document proposes a design for a comprehensive vic-machine API, the implementation of which will be tracked by #6116. Subsets of this API (tracked by #5721, #6123, and eventually others) will be implemented incrementally, and the design will be revised as those efforts progress to reflect changes to the long-term vision. * Remove superfluous calls to Set Test VCH Name (#7304) Several tests explicitly call the `Set Test VCH Name` keyword shortly after calling `Set Test Environment Variables`. This can lead to test failures when a VCH name collision occurs; subsequent tests which re-use the VCH name fail because there may be leftover certificates from the first VCH with that name. `Set Test Environment Variables` itself calls `Set Test VCH Name` and then cleans up old certificate directories. Therefore, the explicit calls to `Set Test VCH Name` are both superfluous and problematic. * Ensure that static ip worker is on the same nimbus pod as VC otherwise network connectivity not guaranteed (#7307) * [skip ci] Add ROBO test plans (#7297) This commit adds test plans for the ROBO support features in a new directory (Group19-ROBO) under manual test cases. The existing ROBO-SKU test has been moved into this directory. The test plans include tests for the container limit feature, placement without DRS, the license/ feature checks and WAN connectivity. Fixes #7294 * Add hosts to DVS within the test bed as well (#7326) * Setup updated for Longevity Tests (#7298) * Setup updated for Longevity Tests to run on 6.5U1 * [skip ci] Terminate gracefully to gather logs (#7331) * Terminate gracefully to gather logs * Remove extra whitespace * Increase timeout to 70 minutes * Increase ELM timeout to 70 minutes * Add repo to slack message since we have multiple repos reporting now (#7334) * Not sending user credentials with every request (#6382) * Add concurrent testing tool to tests folder (#6534) Adds a minimized test case for testing our core vSphere interactions at varying degrees of concurrency. This is intended to simplify debugging issues that are suspected to be platform problems, or API usage issues that are conceptually divorced from the VIC engine product code. * Refactor Install Harbor To Test Server keyword (#7335) The secret tag on the `Install Harbor To Test Server` makes it difficult to investigate failures when they occur. Only one out of 30+ lines actually uses secret information. Refactor the keyword to extract the secret information into its own keyword, allowing the tag to be applied in a more focused way. This is similar to the pattern used by keywords in `VCH-Util`. * Add ability to cache generated dependency. (#7340) * Add ability to cache generated dependency, so not much time wasted during the build process. * Added documentation to reflect necessary steps to leverage such improvements. * Ignore not-supported result from RetrieveUserGroups in VC 6.0 (#7328) * Move build time directives from title to body of PR (#7060) * Retry the harbor setup as well (#7336) * Skip non vSphere managed datastores when granting perms (#7346) * Fix volume leak on group 23 test (#7358) * Fix github status automation filtering (#7344) Adds filtering for the event source and consolidates remote API calls. Details the specific builds and their status for quick reference. * Drone 0.8 and HaaS updates (#7364) * Add tether.debug in integration test log bundle (#7422) * Update the gcs plugin (#7421) * [skip ci] Suggest subnet/gateway to static ip worker * Ensure that static ip worker is on the same nimbus pod as VC otherwise network connectivity not guaranteed (#7307) * Refactored some proxy code to reuse with wolfpack Refactored the system, volume, container, and stream swagger code into proxy code. 1) Moved the errors.go from backends to a new folder to be accessed by all folders outside of the backends folder. 2) Refactored Container proxy and moved from engine/backends to engine/proxy 3) Refactored Volume proxy and moved from engine/backends to engine/proxy 4) Refactored System proxy and moved from engine/backends to engine/proxy 5) Refactored Stream proxy and moved from engine/backends to engine/proxy 6) Adopted some common patterns in all the proxies 7) Moved common networking util calls to engine/networking 8) Fix up unit tests 9) Changed all "not yet implemented messages" 10) Updated robot scripts More refactoring will be needed to make these proxy less dependent on docker types and portlayer swagger types. Helps resolves #7210 and #7232 * Add virtual-kubelet binary to VIC ISO (#7315) * Start virtual-kubelet inside the VCH (#7369) * Fix value of the PORTLAYER_ADDR environment variable (#7400) * Use vic kubelet provider * Made modifications for virtual kubelet * Added admin log collection and fix env variable content (#7404) * Added most-vkubelet target (#7418)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarifying the priority definitions for all features and non-bug issues.
For 1.4.0 - The two Anchor Features are ROBO and the Quality Work (OKR). They are the only non-bug issues (based on the definition above) that should be p1. Wizard work would be considered p2. Photon OS 2.0 is p3. The wolfpack work should be considered p4 as it is not 1.4.0 at all.
Only P0 and P1's (Both bug and feature) should be added to the 1.4.0 All releases tracking.