Skip to content

Add logging for image upload, handle datastore stat error #7296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrewtchin merged 2 commits into from
Feb 13, 2018
Merged

Add logging for image upload, handle datastore stat error #7296

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
723a645
Add logging for image upload
Feb 8, 2018
3e880ea
Merge branch 'master' into 7007-nightly-multi-vlan
andrewtchin Feb 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions lib/install/management/create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,14 +139,16 @@ func (d *Dispatcher) uploadImages(files map[string]string) error {

isoTargetPath := path.Join(d.vmPathName, key)
// check iso first
d.op.Debugf("target delete path = %s", isoTargetPath)
_, err := ds.Stat(d.op, isoTargetPath)
if err != nil {
switch err.(type) {
case object.DatastoreNoSuchFileError:
// if not found, do nothing
d.op.Debug("File not found. Nothing to do.")
case object.DatastoreNoSuchDirectoryError:
d.op.Debug("Directory not found. Nothing to do.")
default:
// otherwise force delete
d.op.Debugf("target delete path = %s", isoTargetPath)
err := fm.Delete(d.op, isoTargetPath)
if err != nil {
d.op.Debugf("Failed to delete image (%s) with error (%s)", image, err.Error())
Expand Down