vic-machine: Fix message from inspect config#7544
Merged
zjs merged 2 commits intovmware:masterfrom May 14, 2018
Merged
Conversation
The `vic-machine inspect config` command describes the current state of the target VCH. When this command was implemented, this was equivalent to the options used to create the VCH. Since then, the `vic-machine configure` command has been added. This change corrects the phrasing of the message to clearly communicate that the output is the current state of the VCH, not the initial creation options.
zjs
added
area/cli
AngieCris
approved these changes
Mar 19, 2018
Codecov Report
@@ Coverage Diff @@
## master #7544 +/- ##
=======================================
Coverage 26.34% 26.34%
=======================================
Files 37 37
Lines 5189 5189
=======================================
Hits 1367 1367
Misses 3715 3715
Partials 107 107Continue to review full report at Codecov.
|
zjs
commented
Mar 19, 2018
Member
Author
zjs
left a comment
zjs
left a comment
There was a problem hiding this comment.
Before submitting, I should ensure that we have a test case which verifies that this output is indeed updated following a configure operation.
andrewtchin
approved these changes
Mar 20, 2018
zjs
added a commit
to zjs/vic
that referenced
this pull request
Jun 21, 2018
The `vic-machine inspect config` command describes the current state of the target VCH. When this command was implemented, this was equivalent to the options used to create the VCH. Since then, the `vic-machine configure` command has been added. This change corrects the phrasing of the message to clearly communicate that the output is the current state of the VCH, not the initial creation options. (cherry picked from commit 7662397)
zjs
added a commit
to zjs/vic
that referenced
this pull request
Jun 22, 2018
The `vic-machine inspect config` command describes the current state of the target VCH. When this command was implemented, this was equivalent to the options used to create the VCH. Since then, the `vic-machine configure` command has been added. This change corrects the phrasing of the message to clearly communicate that the output is the current state of the VCH, not the initial creation options. (cherry picked from commit 7662397)
zjs
added a commit
to zjs/vic
that referenced
this pull request
Jun 28, 2018
The `vic-machine inspect config` command describes the current state of the target VCH. When this command was implemented, this was equivalent to the options used to create the VCH. Since then, the `vic-machine configure` command has been added. This change corrects the phrasing of the message to clearly communicate that the output is the current state of the VCH, not the initial creation options. (cherry picked from commit 7662397)
zjs
added a commit
to zjs/vic
that referenced
this pull request
Jul 2, 2018
The `vic-machine inspect config` command describes the current state of the target VCH. When this command was implemented, this was equivalent to the options used to create the VCH. Since then, the `vic-machine configure` command has been added. This change corrects the phrasing of the message to clearly communicate that the output is the current state of the VCH, not the initial creation options. (cherry picked from commit 7662397)
zjs
added a commit
to zjs/vic
that referenced
this pull request
Jul 2, 2018
The `vic-machine inspect config` command describes the current state of the target VCH. When this command was implemented, this was equivalent to the options used to create the VCH. Since then, the `vic-machine configure` command has been added. This change corrects the phrasing of the message to clearly communicate that the output is the current state of the VCH, not the initial creation options. (cherry picked from commit 7662397)
zjs
added a commit
to zjs/vic
that referenced
this pull request
Jul 12, 2018
The `vic-machine inspect config` command describes the current state of the target VCH. When this command was implemented, this was equivalent to the options used to create the VCH. Since then, the `vic-machine configure` command has been added. This change corrects the phrasing of the message to clearly communicate that the output is the current state of the VCH, not the initial creation options. (cherry picked from commit 7662397)
zjs
added a commit
to zjs/vic
that referenced
this pull request
Jul 27, 2018
The `vic-machine inspect config` command describes the current state of the target VCH. When this command was implemented, this was equivalent to the options used to create the VCH. Since then, the `vic-machine configure` command has been added. This change corrects the phrasing of the message to clearly communicate that the output is the current state of the VCH, not the initial creation options. (cherry picked from commit 7662397)
zjs
added a commit
that referenced
this pull request
Jul 27, 2018
The `vic-machine inspect config` command describes the current state of the target VCH. When this command was implemented, this was equivalent to the options used to create the VCH. Since then, the `vic-machine configure` command has been added. This change corrects the phrasing of the message to clearly communicate that the output is the current state of the VCH, not the initial creation options. (cherry picked from commit 7662397)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
vic-machine inspect configcommand describes the current state of the target VCH. When this command was implemented, this was equivalent to the options used to create the VCH. Since then, thevic-machine configurecommand has been added. This change corrects the phrasing of the message to clearly communicate that the output is the current state of the VCH, not the initial creation options.