Skip to content

Add ping to NFS Volume nightly tests [skip ci]#7821

Merged
mdharamadas1 merged 5 commits intovmware:masterfrom
andrewtchin:7601/logging
May 11, 2018
Merged

Add ping to NFS Volume nightly tests [skip ci]#7821
mdharamadas1 merged 5 commits intovmware:masterfrom
andrewtchin:7601/logging

Conversation

@andrewtchin
Copy link
Contributor

@andrewtchin andrewtchin commented Apr 24, 2018

Fixes #7601
[skip ci]

@andrewtchin andrewtchin changed the title Add ping to NFS Volume nightly tests Add ping to NFS Volume nightly tests [skip ci] Apr 24, 2018
@codecov-io
Copy link

codecov-io commented Apr 24, 2018

Codecov Report

Merging #7821 into master will decrease coverage by 0.48%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7821      +/-   ##
==========================================
- Coverage   26.34%   25.85%   -0.49%     
==========================================
  Files          37       35       -2     
  Lines        5189     5124      -65     
==========================================
- Hits         1367     1325      -42     
+ Misses       3715     3692      -23     
  Partials      107      107
Impacted Files Coverage Δ
cmd/vic-machine/common/compute.go 0% <0%> (ø) ⬆️
cmd/vic-machine/common/help.go
cmd/vic-machine/common/completion.go
cmd/vic-machine/create/create.go 42.43% <0%> (+1.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d09ccd6...c63938d. Read the comment docs.

Ping VCH
${rc} ${out}= Ping Host %{VCH-IP}
Log ${rc}
Log ${out}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check that these pings succeed here, then where you call the ping nfs server/vch keyword wrap it in wait until keyword succeeds for about 10 minutes to try to and wait until the network disruption subsides before failing the test

@mdharamadas1
Copy link
Contributor

All, this is ready for re-review.

Copy link
Contributor

@rajanashok rajanashok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mdharamadas1 mdharamadas1 merged commit 71664a5 into vmware:master May 11, 2018
zjs pushed a commit to zjs/vic that referenced this pull request Jul 19, 2018
zjs pushed a commit to zjs/vic that referenced this pull request Jul 27, 2018
zjs pushed a commit that referenced this pull request Jul 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants