Conversation
When rolling back an upgrade, clearly log that we are doing so.
zjs
requested review from
a user,
andrewtchin,
cgtexmex,
mhagen-vmware and
stuclem
Codecov Report
@@ Coverage Diff @@
## master #7830 +/- ##
=======================================
Coverage 25.85% 25.85%
=======================================
Files 35 35
Lines 5124 5124
=======================================
Hits 1325 1325
Misses 3692 3692
Partials 107 107Continue to review full report at Codecov.
|
|
|
||
| op.Infof("### Upgrading VCH ####") | ||
| var action management.Action | ||
| if !u.Data.Rollback { |
There was a problem hiding this comment.
can you remove negation and swap if/else blocks?
There was a problem hiding this comment.
I considered that. Usually I prefer to avoid negation, but in this case it seemed more intuitive to have the upgrade case first, in part for consistency with the rest of the file:
vic/cmd/vic-machine/upgrade/upgrade.go
Line 124 in 538f1de
vic/cmd/vic-machine/upgrade/upgrade.go
Line 224 in 538f1de
When rolling back an upgrade, clearly log that we are doing so. (cherry picked from commit 2c4dde9)
When rolling back an upgrade, clearly log that we are doing so. (cherry picked from commit 2c4dde9)
When rolling back an upgrade, clearly log that we are doing so. (cherry picked from commit 2c4dde9)
When rolling back an upgrade, clearly log that we are doing so. (cherry picked from commit 2c4dde9)
When rolling back an upgrade, clearly log that we are doing so. (cherry picked from commit 2c4dde9)
When rolling back an upgrade, clearly log that we are doing so. (cherry picked from commit 2c4dde9)
7 participants
When rolling back an upgrade, clearly log that we are doing so.
Fixes #6686