Include VCH IP and management IP in create and inspect output#7832
Merged
zjs merged 4 commits intovmware:masterfrom Apr 25, 2018
Merged
Include VCH IP and management IP in create and inspect output#7832zjs merged 4 commits intovmware:masterfrom
zjs merged 4 commits intovmware:masterfrom
Conversation
Allow users to take note of the VCH endpoint VM's ID for debugging or use with subsequent vic-machine commands.
The public and client IPs are already included. Output the management IP as well.
Codecov Report
@@ Coverage Diff @@
## master #7832 +/- ##
==========================================
+ Coverage 25.85% 26.07% +0.21%
==========================================
Files 35 35
Lines 5124 5124
==========================================
+ Hits 1325 1336 +11
+ Misses 3692 3683 -9
+ Partials 107 105 -2
Continue to review full report at Codecov.
|
andrewtchin
approved these changes
Apr 25, 2018
vburenin
reviewed
Apr 25, 2018
|
|
||
| func (d *Dispatcher) ShowVCH(conf *config.VirtualContainerHostConfigSpec, key string, cert string, cacert string, envfile string, certpath string) { | ||
| moref := new(types.ManagedObjectReference) | ||
| if ok := moref.FromString(conf.ID); ok { |
Member
Author
There was a problem hiding this comment.
I don't know of a case where we'd get !ok.
vburenin
reviewed
Apr 25, 2018
lib/install/management/inspect.go
Outdated
| d.op.Infof("%s", publicIP.String()) | ||
|
|
||
| d.op.Info("") | ||
| managementIP := conf.ExecutorConfig.Networks["management"].Assigned.IP |
Contributor
There was a problem hiding this comment.
are you sure you never get nil somewhere in the middle?
Member
Author
There was a problem hiding this comment.
Currently, we should be okay, but perhaps it would be good to be defensive here in case something changes in the future.
AngieCris
approved these changes
Apr 25, 2018
zjs
added a commit
to zjs/vic
that referenced
this pull request
Jun 21, 2018
Allow users to take note of the VCH endpoint VM's ID for debugging or use with subsequent vic-machine commands. Additionally, output the management IP. (cherry picked from commit 696cb97)
zjs
added a commit
to zjs/vic
that referenced
this pull request
Jun 22, 2018
Allow users to take note of the VCH endpoint VM's ID for debugging or use with subsequent vic-machine commands. Additionally, output the management IP. (cherry picked from commit 696cb97)
zjs
added a commit
to zjs/vic
that referenced
this pull request
Jun 28, 2018
Allow users to take note of the VCH endpoint VM's ID for debugging or use with subsequent vic-machine commands. Additionally, output the management IP. (cherry picked from commit 696cb97)
zjs
added a commit
to zjs/vic
that referenced
this pull request
Jul 2, 2018
Allow users to take note of the VCH endpoint VM's ID for debugging or use with subsequent vic-machine commands. Additionally, output the management IP. (cherry picked from commit 696cb97)
zjs
added a commit
to zjs/vic
that referenced
this pull request
Jul 2, 2018
Allow users to take note of the VCH endpoint VM's ID for debugging or use with subsequent vic-machine commands. Additionally, output the management IP. (cherry picked from commit 696cb97)
zjs
added a commit
to zjs/vic
that referenced
this pull request
Jul 27, 2018
Allow users to take note of the VCH endpoint VM's ID for debugging or use with subsequent vic-machine commands. Additionally, output the management IP. (cherry picked from commit 696cb97)
zjs
added a commit
that referenced
this pull request
Jul 27, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow users to take note of the VCH endpoint VM's ID for debugging or use with subsequent vic-machine commands.
The public and client IPs are already included. Output the management IP as well.
Fixes: #6517
Example
createoutput:Example
inspectoutput: