Address spreading use of secret tag in our curl commands#7862
Merged
mhagen-vmware merged 4 commits intomasterfrom May 1, 2018
Merged
Address spreading use of secret tag in our curl commands#7862mhagen-vmware merged 4 commits intomasterfrom
mhagen-vmware merged 4 commits intomasterfrom
Conversation
mhagen-vmware
requested review from
mdharamadas1,
rajanashok,
rogeliosanchez and
singhshwetaQE
zjs
reviewed
Apr 30, 2018
Member
zjs
left a comment
zjs
left a comment
There was a problem hiding this comment.
Can we put the repeated logic in a keyword to ensure it's applied consistently?
Contributor
Author
|
@zjs done |
zjs
approved these changes
May 1, 2018
Codecov Report
@@ Coverage Diff @@
## master #7862 +/- ##
=======================================
Coverage 26.34% 26.34%
=======================================
Files 37 37
Lines 5189 5189
=======================================
Hits 1367 1367
Misses 3715 3715
Partials 107 107Continue to review full report at Codecov.
|
zjs
pushed a commit
to zjs/vic
that referenced
this pull request
Jul 27, 2018
(cherry picked from commit 050999c)
zjs
pushed a commit
to zjs/vic
that referenced
this pull request
Aug 2, 2018
vmware#8162) (cherry picked from commit 050999c)
zjs
pushed a commit
that referenced
this pull request
Aug 7, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #5358
Too large of a keyword tagged in secret makes it impossible to debug failures.
[skip unit]
[specific ci=Group9-VIC-Admin]