Skip to content

Use 1.3.1 in ops user upgrade test #7874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jzt merged 1 commit into from
May 1, 2018
Merged

Use 1.3.1 in ops user upgrade test #7874

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/manual-test-cases/Group5-Functional-Tests/5-25-OPS-User-Grant.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ This test requires access to VMware Nimbus cluster for dynamic ESXi and vCenter
7. Create a container
8. Use govc to attempt to out-of-band destroy the container from Step 7
9. Clean up the VCH
10. Install version v1.3.0 of the VIC appliance into the cluster with the --ops-grant-perms option
10. Install version v1.3.1 of the VIC appliance into the cluster with the --ops-grant-perms option
11. Perform a VCH upgrade to the current version
12. With the ops-user, use govc to attempt to create a resource pool
13. Run a variety of docker operations on the VCH
Expand Down
37 changes: 16 additions & 21 deletions tests/manual-test-cases/Group5-Functional-Tests/5-25-OPS-User-Grant.robot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ Documentation Test 5-25 - OPS-User-Grant
Resource ../../resources/Util.robot
Suite Setup Wait Until Keyword Succeeds 10x 10m Ops User Create
Suite Teardown Run Keyword And Ignore Error Nimbus Cleanup ${list}
Test Teardown Run Keyword If Test Failed Gather vSphere Logs

*** Keywords ***
Ops User Create
Expand Down Expand Up @@ -139,27 +138,23 @@ vic-machine create grants ops-user perms

Run privilege-dependent docker operations

Cleanup VIC Appliance On Test Server
[Teardown] Cleanup VIC Appliance On Test Server
Copy link
Contributor

@AngieCris AngieCris May 1, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one thing I'm not very sure about: does this teardown overwrite the global teardown Run Keyword If Test Failed Gather vSphere Logs?
For example if the test failed, does it run Cleanup VIC Appliance On Test Server first and then Gather vSphere Logs? Or it only runs Cleanup VIC Appliance On Test Server because that's how we defined it

Copy link
Contributor Author

@jzt jzt May 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would override, but since we don't really need the vsphere logs from these tests, we can get rid of the global teardown.


granted ops-user perms work after upgrade
${status}= Get State Of Github Issue 7796
Run Keyword If '${status}' == 'closed' Fail Test 5-25-OPS-User-Grant.robot needs to be updated now that Issue #7796 has been resolved
Log Issue \#7796 is blocking implementation WARN

#Install VIC with version to Test Server v1.3.0 additional-args=--ops-user ${ops_user_name} --ops-password ${ops_user_password} --ops-grant-perms
#
#Check Original Version
#Upgrade
#Check Upgraded Version
#
Install VIC with version to Test Server v1.3.1 additional-args=--ops-user ${ops_user_name} --ops-password ${ops_user_password} --ops-grant-perms

Check Original Version
Upgrade
Check Upgraded Version

# Run a govc test to check that access is denied on some resources
#Attempt To Create Resource Pool
#
#Run Regression Tests
#
#Run privilege-dependent docker operations
#
#Cleanup VIC Appliance On Test Server
Attempt To Create Resource Pool

Run Regression Tests

Run privilege-dependent docker operations

[Teardown] Cleanup VIC Appliance On Test Server

Test with VM-Host Affinity
Log To Console \nStarting test...
Expand All @@ -172,7 +167,7 @@ Test with VM-Host Affinity

Run privilege-dependent docker operations

Cleanup VIC Appliance On Test Server
[Teardown] Cleanup VIC Appliance On Test Server

vic-machine configure grants ops-user perms
Install VIC Appliance To Test Server
Expand All @@ -184,4 +179,4 @@ vic-machine configure grants ops-user perms

Run privilege-dependent docker operations

Cleanup VIC Appliance On Test Server
[Teardown] Cleanup VIC Appliance On Test Server