[skip ci] Configure ROBO nightlies with Group19-DRS-Disabled#7876
[skip ci] Configure ROBO nightlies with Group19-DRS-Disabled#7876anchal-agrawal merged 1 commit intovmware:masterfrom
Conversation
| @@ -0,0 +1,72 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
This file is similar to tests/nightly/jenkins-nightly-run.sh except at the bottom, where we're running a different test suite.
| @@ -0,0 +1,56 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
This file is similar to tests/nightly/upload-logs.sh except that the log artifact names and storage buckets are different.
anchal-agrawal
force-pushed
the
7662-robo-nightly
branch
from
635a553 to
d7559fa
Compare
Codecov Report
@@ Coverage Diff @@
## master #7876 +/- ##
=======================================
Coverage 26.34% 26.34%
=======================================
Files 37 37
Lines 5189 5189
=======================================
Hits 1367 1367
Misses 3715 3715
Partials 107 107Continue to review full report at Codecov.
|
cgtexmex
left a comment
cgtexmex
left a comment
There was a problem hiding this comment.
Only nit is the use of ROBO in some names...that will lose meaning as time goes by and doesn't match the test suite, etc..
mhagen-vmware
left a comment
mhagen-vmware
left a comment
There was a problem hiding this comment.
lgtm, just a couple of changes I would like to see
tests/robo/jenkins-robo-run.sh
Outdated
|
|
||
| pybot --removekeywords TAG:secret -d robo tests/manual-test-cases/Group19-DRS-Disabled > robo/stdout.txt | ||
|
|
||
| cat robo/stdout.txt | grep '::' | grep -E 'PASS|FAIL' > console.log |
There was a problem hiding this comment.
Use the latest grep from vic-product (change initial grep to grep -E '::|...'):
https://github.com/vmware/vic-product/blob/master/tests/vic-product-nightly.sh#L52
tests/robo/jenkins-robo-run.sh
Outdated
| echo "Tarball extraction passed, Running nightlies test.." | ||
| fi | ||
|
|
||
| pybot --removekeywords TAG:secret -d robo tests/manual-test-cases/Group19-DRS-Disabled > robo/stdout.txt |
There was a problem hiding this comment.
run this in a container to be more jenkins workspace compatible:
https://github.com/vmware/vic-product/blob/master/tests/vic-product-nightly.sh#L51
There was a problem hiding this comment.
Not sure I'm following. The jenkins job runs this script in a docker container
#!/bin/bash
docker run -v $PWD/vic:/go --env-file <secrets file path> gcr.io/eminent-nation-87317/vic-integration-test:1.48 tests/robo/jenkins-robo-run.shwhereas the vic-product-nightly job runs the script directly.
There was a problem hiding this comment.
right, I want to move to the latter approach across the board
There was a problem hiding this comment.
vic-engine nightlies aren't fully there, but product and longevity have already been converted. I would prefer you start from where we are now otherwise I have to go in an convert it later again. But I am not blocking your PR on this either way.
There was a problem hiding this comment.
Done - thanks! Please give this script another look. Key changes:
- the script runs on the executor directly
- the
pabotcommand runs in a container - the log upload script runs in a second container
- all paths/references to
roboupdated todrs-disabled, per @cgtexmex's feedback
anchal-agrawal
force-pushed
the
7662-robo-nightly
branch
from
d7559fa to
b6d222b
Compare
|
@cgtexmex Thanks - updated all paths/references to |
anchal-agrawal
changed the title
anchal-agrawal
force-pushed
the
7662-robo-nightly
branch
from
b6d222b to
1d25176
Compare
This commit adds test scripts for running a nightly Jenkins job to run tests in a non-DRS environment. This change runs the Group19-DRS-Disabled suite against a pre-deployed, static vCenter ELM testbed. The corresponding secrets file will be committed to the internal repo. Future changes will include adding more tests and using a testbed deployed with a service account. Fixes vmware#7662
anchal-agrawal
force-pushed
the
7662-robo-nightly
branch
from
1d25176 to
9393407
Compare
…7876) This commit adds test scripts for running a nightly Jenkins job to run tests in a non-DRS environment. This change runs the Group19-DRS-Disabled suite against a pre-deployed, static vCenter ELM testbed. The corresponding secrets file will be committed to the internal repo. Future changes will include adding more tests and using a testbed deployed with a service account. Fixes vmware#7662 (cherry picked from commit fe040e0)
…are#8151) This commit adds test scripts for running a nightly Jenkins job to run tests in a non-DRS environment. This change runs the Group19-DRS-Disabled suite against a pre-deployed, static vCenter ELM testbed. The corresponding secrets file will be committed to the internal repo. Future changes will include adding more tests and using a testbed deployed with a service account. Fixes vmware#7662 (cherry picked from commit fe040e0)
This commit adds test scripts for running a nightly Jenkins job to run tests in a non-DRS environment. This change runs the Group19-DRS-Disabled suite against a pre-deployed, static vCenter ELM testbed. The corresponding secrets file will be committed to the internal repo. Future changes will include adding more tests and using a testbed deployed with a service account. Fixes #7662 (cherry picked from commit fe040e0)
6 participants
This commit adds test scripts for running a nightly Jenkins job to
run tests in a non-DRS environment. This change runs the
Group19-DRS-Disabled suite against a pre-deployed, static vCenter
ELM testbed. The corresponding secrets file will be committed to
the internal repo.
Future changes will include adding more tests and using a testbed
deployed with a service account.
Fixes #7662