Skip to content

Fix several tests that did not appropriately use the vic-admin env var#7879

Merged
mhagen-vmware merged 2 commits intomasterfrom
feature/fix-vic-admin
May 2, 2018
Merged

Fix several tests that did not appropriately use the vic-admin env var#7879
mhagen-vmware merged 2 commits intomasterfrom
feature/fix-vic-admin

Conversation

@mhagen-vmware
Copy link
Contributor

@mhagen-vmware mhagen-vmware commented May 2, 2018

[skip unit]
[specific ci=23-02-VCH-List --suite 24-01-Multi-VCH-PS --suite 24-02-Multi-VCH-Delete --suite 6-13-TLS]

  1. remove the empty vch list test, that needs to be re-implemented in our nightlies otherwise we can never run parallel jobs
  2. make sure to set VIC-ADMIN in the multi-vch tests so that gather logs will work
  3. update the docker params with the newer VCH installed

Copy link
Contributor

@rajanashok rajanashok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zjs
Copy link
Member

zjs commented May 2, 2018

remove the empty vch list test, that needs to be re-implemented in our nightlies otherwise we can never run parallel jobs

Could we file an issue to track re-introducing this?

@mhagen-vmware
Copy link
Contributor Author

#7880

@mhagen-vmware mhagen-vmware merged commit b5bad94 into master May 2, 2018
@mhagen-vmware mhagen-vmware deleted the feature/fix-vic-admin branch May 2, 2018 19:08
zjs pushed a commit to zjs/vic that referenced this pull request Jul 19, 2018
zjs pushed a commit to zjs/vic that referenced this pull request Jul 27, 2018
zjs pushed a commit that referenced this pull request Jul 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants