[skip ci] Add test for no-DRS VCH create with RP options#7881
Merged
anchal-agrawal merged 1 commit intovmware:masterfrom May 4, 2018
Merged
[skip ci] Add test for no-DRS VCH create with RP options#7881anchal-agrawal merged 1 commit intovmware:masterfrom
anchal-agrawal merged 1 commit intovmware:masterfrom
Conversation
cgtexmex
approved these changes
May 2, 2018
Codecov Report
@@ Coverage Diff @@
## master #7881 +/- ##
==========================================
- Coverage 31.05% 26.34% -4.72%
==========================================
Files 295 37 -258
Lines 43709 5189 -38520
==========================================
- Hits 13576 1367 -12209
+ Misses 28951 3715 -25236
+ Partials 1182 107 -1075Continue to review full report at Codecov.
|
anchal-agrawal
changed the title
mhagen-vmware
approved these changes
May 3, 2018
Contributor
mhagen-vmware
left a comment
mhagen-vmware
left a comment
There was a problem hiding this comment.
lgtm, however it looks like to me that the robo manual test jenkins job is still not setup. We should not continue to add much more tests without getting that finished.
| This test requires access to VMware Nimbus cluster for dynamic ESXi and vCenter creation. This test should be executed in the following topologies and should have vSAN enabled. | ||
| * 1 vCenter host with 3 clusters, where 1 cluster has 1 ESXi host and the other 2 clusters have 3 ESXi hosts each | ||
| * 2 vCenter hosts connected with ELM, where each vCenter host has a cluster/host/datacenter topology that emulates a customer environment (exact topology TBD) | ||
| * 1 PSC linking 2 VCs, each containing a 3-host cluster with VSAN enabled and DRS disabled, and a single host cluster. |
Contributor
There was a problem hiding this comment.
not sure why this test needs any of these features other than a simple cluster with DRS disabled
matthewavery
approved these changes
May 3, 2018
This commit adds an integration test in Group19-DRS-Disabled to verify that during a VCH create, vic-machine checks for the DRS setting in the targeted cluster and also warns if any command options specific to resource pools are supplied, since they will be ignored as they are not applicable in a DRS-disabled env. Towards vmware#7275
zjs
pushed a commit
to zjs/vic
that referenced
this pull request
Jul 19, 2018
This commit adds an integration test in Group19-DRS-Disabled to verify that during a VCH create, vic-machine checks for the DRS setting in the targeted cluster and also warns if any command options specific to resource pools are supplied, since they will be ignored as they are not applicable in a DRS-disabled env. Towards vmware#7275 (cherry picked from commit e3991c1)
zjs
pushed a commit
to zjs/vic
that referenced
this pull request
Jul 27, 2018
…8151) This commit adds an integration test in Group19-DRS-Disabled to verify that during a VCH create, vic-machine checks for the DRS setting in the targeted cluster and also warns if any command options specific to resource pools are supplied, since they will be ignored as they are not applicable in a DRS-disabled env. Towards vmware#7275 (cherry picked from commit e3991c1)
zjs
pushed a commit
that referenced
this pull request
Jul 27, 2018
This commit adds an integration test in Group19-DRS-Disabled to verify that during a VCH create, vic-machine checks for the DRS setting in the targeted cluster and also warns if any command options specific to resource pools are supplied, since they will be ignored as they are not applicable in a DRS-disabled env. Towards #7275 (cherry picked from commit e3991c1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds an integration test in Group19-DRS-Disabled to
verify that during a VCH create, vic-machine checks for the DRS
setting in the targeted cluster and also warns if any command
options specific to resource pools are supplied, since they will
be ignored as they are not applicable in a DRS-disabled env.
Towards #7275