VCH install timeout set to 30m for 5-21-Datastore-Path#7902
Merged
cgtexmex merged 1 commit intovmware:masterfrom May 4, 2018
Merged
VCH install timeout set to 30m for 5-21-Datastore-Path#7902cgtexmex merged 1 commit intovmware:masterfrom
cgtexmex merged 1 commit intovmware:masterfrom
Conversation
cgtexmex
requested review from
anchal-agrawal,
mdharamadas1,
mhagen-vmware and
rogeliosanchez
| Remove Environment Variable PUBLIC_NETWORK | ||
|
|
||
| ${output}= Install VIC Appliance To Test Server certs=${false} | ||
| ${output}= Install VIC Appliance To Test Server certs=${false} additional-args=--timeout=%{TEST_TIMEOUT} |
Contributor
There was a problem hiding this comment.
This keyword runs vic-machine create with --timeout=%{TEST_TIMEOUT}: https://github.com/vmware/vic/blob/master/tests/resources/VCH-Util.robot#L340
We're setting TEST_TIMEOUT to 30m on line 39, so if I'm understanding correctly, I don't think we need to change this line.
Contributor
Author
There was a problem hiding this comment.
Yep agreed -- I got lost in the VCH-Util.robot redirection...and also confused the 2nd & 3rd tests...
| Log To Console \nRunning custom vic-machine create - with DS Scheme in Volume Store | ||
| # Need to run custom vic-machine create to specify volume store with DS scheme | ||
| ${output}= Run bin/vic-machine-linux create --debug 1 --name=%{VCH-NAME} --target=%{TEST_URL_ARRAY} --user=%{TEST_USERNAME} --bridge-network=%{BRIDGE_NETWORK} --public-network=%{PUBLIC_NETWORK} --image-store=%{TEST_DATASTORE} --volume-store=${dsScheme}%{TEST_DATASTORE}/images:default --password=%{TEST_PASSWORD} --appliance-iso=bin/appliance.iso --bootstrap-iso=bin/bootstrap.iso --insecure-registry harbor.ci.drone.local --force --kv | ||
| ${output}= Run bin/vic-machine-linux create --debug 1 --name=%{VCH-NAME} --target=%{TEST_URL_ARRAY} --user=%{TEST_USERNAME} --bridge-network=%{BRIDGE_NETWORK} --public-network=%{PUBLIC_NETWORK} --image-store=%{TEST_DATASTORE} --volume-store=${dsScheme}%{TEST_DATASTORE}/images:default --password=%{TEST_PASSWORD} --appliance-iso=bin/appliance.iso --bootstrap-iso=bin/bootstrap.iso --insecure-registry harbor.ci.drone.local --force --kv --timeout=%{TEST_TIMEOUT} |
Codecov Report
@@ Coverage Diff @@
## master #7902 +/- ##
==========================================
- Coverage 31.12% 26.34% -4.79%
==========================================
Files 295 37 -258
Lines 43709 5189 -38520
==========================================
- Hits 13606 1367 -12239
+ Misses 28919 3715 -25204
+ Partials 1184 107 -1077Continue to review full report at Codecov.
|
Increases timeout from default 3m to 30m Toward vmware#7718
Contributor
Author
|
@anchal-agrawal fixed... |
anchal-agrawal
approved these changes
May 4, 2018
Contributor
anchal-agrawal
left a comment
anchal-agrawal
left a comment
There was a problem hiding this comment.
TIL --kv = --no-tlsverify in vic-machine create
zjs
pushed a commit
to zjs/vic
that referenced
this pull request
Jul 19, 2018
Increases timeout from default 3m to 30m Toward vmware#7718 (cherry picked from commit 0e43ea6)
zjs
pushed a commit
to zjs/vic
that referenced
this pull request
Jul 27, 2018
…mware#8151) Increases timeout from default 3m to 30m Toward vmware#7718 (cherry picked from commit 0e43ea6)
zjs
pushed a commit
that referenced
this pull request
Jul 27, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Increases timeout from default 3m to 30m
Toward #7718
[skip ci]