Skip to content

Add NFS datastore keyword back#7906

Merged
mhagen-vmware merged 2 commits intomasterfrom
feature/add-nfs-datastore-back
May 7, 2018
Merged

Add NFS datastore keyword back#7906
mhagen-vmware merged 2 commits intomasterfrom
feature/add-nfs-datastore-back

Conversation

@mhagen-vmware
Copy link
Contributor

fixes #7891

Copy link
Contributor

@rogeliosanchez rogeliosanchez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-io
Copy link

codecov-io commented May 7, 2018

Codecov Report

Merging #7906 into master will decrease coverage by 4.96%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7906      +/-   ##
==========================================
- Coverage    31.3%   26.34%   -4.97%     
==========================================
  Files         295       37     -258     
  Lines       43675     5189   -38486     
==========================================
- Hits        13674     1367   -12307     
+ Misses      28817     3715   -25102     
+ Partials     1184      107    -1077
Impacted Files Coverage Δ
...piservers/service/restapi/handlers/vch_list_get.go
lib/apiservers/engine/backends/build.go
lib/install/management/network.go
lib/spec/scsi.go
lib/portlayer/storage/vsphere/vsphere.go
...apiservers/service/restapi/handlers/version_get.go
lib/portlayer/event/events/base_event.go
lib/config/dynamic/admiral/source.go
lib/apiservers/engine/backends/archive.go
pkg/vsphere/tasks/waiter.go
... and 248 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9816030...5c1fe81. Read the comment docs.

@mhagen-vmware mhagen-vmware merged commit b7784b8 into master May 7, 2018
@mhagen-vmware mhagen-vmware deleted the feature/add-nfs-datastore-back branch May 7, 2018 17:18
zjs pushed a commit to zjs/vic that referenced this pull request Jul 19, 2018
zjs pushed a commit to zjs/vic that referenced this pull request Jul 27, 2018
zjs pushed a commit that referenced this pull request Jul 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nightly 05/01/18 suite setup failed: No keyword with name 'Deploy Nimbus NFS Datastore' found

7 participants