[skip ci]Select correct datastore for the test#7909
Merged
mhagen-vmware merged 6 commits intomasterfrom May 8, 2018
Merged
Conversation
mhagen-vmware
requested review from
mdharamadas1,
rajanashok,
rogeliosanchez and
singhshwetaQE
rajanashok
reviewed
May 7, 2018
| # Get one of the hosts in the cluster we want and make sure we use the correct local datastore | ||
| ${hosts}= Run govc ls -t HostSystem host/cls | ||
| @{hosts}= Split To Lines ${hosts} | ||
| ${datastore}= Get Name of First Local Storage For Host @{hosts}[0] |
Contributor
There was a problem hiding this comment.
Understand it is always a good practice not to hard-code. But Is there a specific reason why we look for the first datastore in the list?
lgtm otherwise.
Contributor
Author
There was a problem hiding this comment.
it is local storage, so it doesn't matter which one just so long as it is on the host.
rajanashok
approved these changes
May 7, 2018
mdharamadas1
approved these changes
May 8, 2018
zjs
pushed a commit
to zjs/vic
that referenced
this pull request
Jul 19, 2018
(cherry picked from commit 86c0c52)
zjs
pushed a commit
to zjs/vic
that referenced
this pull request
Jul 27, 2018
(cherry picked from commit 86c0c52)
zjs
pushed a commit
that referenced
this pull request
Jul 27, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix for the intermittent nightly failure in this test - hasn't been triaged yet, so no ticket for it.
Cleanup old keyword not needed anymore as well