[skip ci] Improving 21-1-Whitelist Test -Harbor Setup#7997
Merged
singhshwetaQE merged 2 commits intovmware:masterfrom May 29, 2018
Merged
[skip ci] Improving 21-1-Whitelist Test -Harbor Setup#7997singhshwetaQE merged 2 commits intovmware:masterfrom
singhshwetaQE merged 2 commits intovmware:masterfrom
Conversation
singhshwetaQE
requested review from
a user,
AngieCris,
mdubya66 and
rogeliosanchez
mhagen-vmware
approved these changes
May 29, 2018
Contributor
mhagen-vmware
left a comment
mhagen-vmware
left a comment
There was a problem hiding this comment.
one small change, otherwise lgtm
| Install Harbor To Test Server protocol=https name=harbor-https | ||
| Set Environment Variable HTTPS_HARBOR_IP %{HARBOR-IP} | ||
|
|
||
| Run Keyword and Ignore Error Remove File ${HARBOR_VERSION}.ova |
Contributor
There was a problem hiding this comment.
don't do this, if it gets to this point then the first install succeeded and we know the file is good.
Contributor
Author
There was a problem hiding this comment.
make sense , I will fix that
ghost
approved these changes
May 29, 2018
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
LGTM, did we decide not to check the shasum of the harbor ova?
zjs
pushed a commit
to zjs/vic
that referenced
this pull request
Jul 19, 2018
* fix 21-1-Whitelist test (cherry picked from commit ef61c13)
zjs
pushed a commit
to zjs/vic
that referenced
this pull request
Jul 27, 2018
* fix 21-1-Whitelist test (cherry picked from commit ef61c13)
zjs
pushed a commit
that referenced
this pull request
Jul 27, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7861
Log output and get rc for wget command
In case of retry for Harbor Setup, remove corrupted/bad file harbor.ova