Fix the for loop in the concurrent rm test which was never working#8017
Merged
mhagen-vmware merged 2 commits intomasterfrom Jun 1, 2018
Merged
Fix the for loop in the concurrent rm test which was never working#8017mhagen-vmware merged 2 commits intomasterfrom
mhagen-vmware merged 2 commits intomasterfrom
Conversation
mhagen-vmware
requested review from
mdharamadas1,
rajanashok,
rogeliosanchez and
singhshwetaQE
zjs
pushed a commit
to zjs/vic
that referenced
this pull request
Jul 27, 2018
…mware#8017) (cherry picked from commit 81d4762)
zjs
pushed a commit
to zjs/vic
that referenced
this pull request
Aug 2, 2018
…mware#8017) (vmware#8162) (cherry picked from commit 81d4762)
zjs
pushed a commit
that referenced
this pull request
Aug 7, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[skip unit]
[specific ci=1-06-Docker-Run]
Missed this because the test intentionally does a docker run --rm which destroys the evidence, but this for loop was never working so all the processes would actually just exit immediately with an error instead of running for a couple of minutes.