Correct suite retry units, delete pxe artifacts#8074
Merged
hickeng merged 5 commits intovmware:masterfrom Jun 21, 2018
Merged
Conversation
lmalvins
reviewed
Jun 19, 2018
| Open Connection %{NIMBUS_GW} | ||
| Wait Until Keyword Succeeds 2 min 30 sec Login %{NIMBUS_USER} %{NIMBUS_PASSWORD} | ||
| Run Keyword If ${deletePXE} Execute Command ${NIMBUS_LOCATION} rm -rf public_html/pxe/* | ||
| Run Keyword If ${deletePXE} Execute Command ${NIMBUS_LOCATION} rm -rf public_html/pxe/* public_html/pxeinstall/* |
There was a problem hiding this comment.
LGTM, we do the same with the vic-ui e2e tests and pxe folder
Checks an error return from a nimbus provisioning call instead of trying to infer status solely from console output. Reduce sleep in inner retry loops during nimbus provisioning to 1m instead of 5m. This should really be parameterized or removed completely in favour of the outer retry logic unless there's significant improvement in success probability from retrying at that level.
hickeng
force-pushed
the
8067b
branch
4 times, most recently
from
81bf9cb to
db2cbe3
Compare
Previously there were retries of different durations wrapped around the outside of the Add Host To Distributed Switch keyword. If it may need retrying then the operation should do so to avoid this cluster, and those cases where a retry was not present.
zjs
approved these changes
Jun 21, 2018
zjs
pushed a commit
to zjs/vic
that referenced
this pull request
Jul 19, 2018
This commit attempts to improve predictability by normalizing error checking, retry approaches, pxe boot directory, and parameterizing previously hard-coded build config. The latter is included because it allows the caller to make reasonable estimates about how the build will run rather than having to dig through test code. Previously there were retries of different durations wrapped around the outside of the Add Host To Distributed Switch keyword. If it may need retrying then the operation should do so to avoid this cluster, and those cases where a retry was not present. Reduce sleep in inner retry loops to fail faster and adds a check for exit code in addition to output parsing for faster fail. The inner loops should be parameterized or removed completely in favour of the outer retry logic unless there's significant improvement in success probability from retrying at that level however this commit does not embark on that work. (cherry picked from commit 1387ab1)
zjs
pushed a commit
to zjs/vic
that referenced
this pull request
Jul 27, 2018
…) (vmware#8151) This commit attempts to improve predictability by normalizing error checking, retry approaches, pxe boot directory, and parameterizing previously hard-coded build config. The latter is included because it allows the caller to make reasonable estimates about how the build will run rather than having to dig through test code. Previously there were retries of different durations wrapped around the outside of the Add Host To Distributed Switch keyword. If it may need retrying then the operation should do so to avoid this cluster, and those cases where a retry was not present. Reduce sleep in inner retry loops to fail faster and adds a check for exit code in addition to output parsing for faster fail. The inner loops should be parameterized or removed completely in favour of the outer retry logic unless there's significant improvement in success probability from retrying at that level however this commit does not embark on that work. (cherry picked from commit 1387ab1)
zjs
pushed a commit
that referenced
this pull request
Jul 27, 2018
…8151) This commit attempts to improve predictability by normalizing error checking, retry approaches, pxe boot directory, and parameterizing previously hard-coded build config. The latter is included because it allows the caller to make reasonable estimates about how the build will run rather than having to dig through test code. Previously there were retries of different durations wrapped around the outside of the Add Host To Distributed Switch keyword. If it may need retrying then the operation should do so to avoid this cluster, and those cases where a retry was not present. Reduce sleep in inner retry loops to fail faster and adds a check for exit code in addition to output parsing for faster fail. The inner loops should be parameterized or removed completely in favour of the outer retry logic unless there's significant improvement in success probability from retrying at that level however this commit does not embark on that work. (cherry picked from commit 1387ab1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retry attempts for suite provisioning were incorrectly being interpreted as
seconds instead of attempts.
The new vSAN testbed spec was using a different pxe folder name than expected
in the folder cleanup logic (
pxeinstallinstead ofpxe) leading to disk quota issues.Add Host To Distributed Switchshould retry within the keyword or not at allfor consistent error handling and behaviour.
Adds parameterization for number of parallel jobs and use of
ops-user.Towards #8067