Fix current encoding errors in syslog test#8095
Merged
hickeng merged 1 commit intovmware:masterfrom Jun 27, 2018
Merged
Conversation
hickeng
approved these changes
Jun 27, 2018
Contributor
hickeng
left a comment
hickeng
left a comment
There was a problem hiding this comment.
Please express why in the commit message.
Use default encoding settings when reading syslog data over SSH to avoid errors when attempting to read some latin1-encoded characters (e.g., mu or u with umlaut) as utf-8. This reverts 58effdf (vmware#7977). Additionally, remove retry of the cat operation; it seems like one of the least likely steps of this process to fail, and code history does not reveal any reason it was added. This reverts 18841ed (vmware#6841).
zjs
changed the title
sflxn
approved these changes
Jun 27, 2018
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use default encoding settings when reading syslog data over SSH to avoid errors when attempting to read some latin1-encoded characters (e.g., mu or u with umlaut) as utf-8.
This reverts 58effdf (#7977).
Additionally, remove retry of the cat operation; it seems like one of the least likely steps of this process to fail, and code history does not reveal any reason it was added.
This reverts 18841ed (#6841).
[specific ci=6-15-Syslog]Additional work exists here. For example, using
catoversshmay not be the best way to read the contents of the file.