Always cache go deps when doing generation#8097
Merged
hickeng merged 1 commit intovmware:masterfrom Jul 30, 2018
Merged
Conversation
zjs
approved these changes
Jun 28, 2018
lcastellano
approved these changes
Jul 17, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change always caches the Go dependencies when they
are generated, and the VIC_CACHE_DEPS variable is then
used solely to control whether the cache is used or whether
dependencies are regenerated.
This is done so that the cache is available for accelerating
make targets even without having had the environment
variable set previously. This change is targeted at local
development productivity.