Revert "vicadmin redirect/force TLS (#7960)"#8165
Merged
zjs merged 1 commit intovmware:masterfrom Aug 7, 2018
Merged
Conversation
Due to the potential for attacks like sslstrip, redirection from HTTP to HTTPS may be as insecure as allowing HTTP traffic in the absence of HSTS. Remove support for redirection until HSTS is supported by VIC. Ref: https://tools.ietf.org/html/rfc6797#section-2.3.1 This reverts commit eebb2cc.
lcastellano
approved these changes
Aug 3, 2018
|
@hickeng if this only relates to accessing the VCH Admin portal, then I think that we're OK. We don't mention HTTP-to-HTTPS redirects in the doc: From https://vmware.github.io/vic-product/assets/files/html/1.4/vic_vsphere_admin/access_vicadmin.html: You access the VCH Admin portal in the following places:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to the potential for attacks like
sslstrip, redirection from HTTP to HTTPS may be as insecure as allowing HTTP traffic in the absence of HSTS. Remove support for redirection until HSTS is supported by VIC.Ref: https://tools.ietf.org/html/rfc6797#section-2.3.1
This reverts commit eebb2cc.
[specific ci=Group9-VIC-Admin]For more information, see vmware/vic-tasks#58.