Support ID-based selection of host via create API#8181
Merged
zhoumeina merged 2 commits intovmware:masterfrom Aug 17, 2018
Merged
Support ID-based selection of host via create API#8181zhoumeina merged 2 commits intovmware:masterfrom
zhoumeina merged 2 commits intovmware:masterfrom
Conversation
Allow a stand-alone host (a host not in a cluster) to be referenced by ID during API-based VCH creation.
hickeng
approved these changes
Aug 7, 2018
Contributor
hickeng
left a comment
hickeng
left a comment
There was a problem hiding this comment.
This looks good. Approved conditional on fixing the unit tests.
wjun
approved these changes
Aug 17, 2018
zjs
added a commit
to zjs/vic
that referenced
this pull request
Aug 28, 2018
* Support ID-based selection of host via create API Allow a stand-alone host (a host not in a cluster) to be referenced by ID during API-based VCH creation. * fixup! Support ID-based selection of host via create API (cherry picked from commit 67f248c) Conflicts: lib/apiservers/service/restapi/handlers/decode/references.go lib/apiservers/service/restapi/handlers/decode/references_test.go lib/apiservers/service/restapi/handlers/vch_create.go
zjs
added a commit
to zjs/vic
that referenced
this pull request
Aug 29, 2018
* Support ID-based selection of host via create API Allow a stand-alone host (a host not in a cluster) to be referenced by ID during API-based VCH creation. * fixup! Support ID-based selection of host via create API (cherry picked from commit 67f248c) Conflicts: lib/apiservers/service/restapi/handlers/decode/references.go lib/apiservers/service/restapi/handlers/decode/references_test.go lib/apiservers/service/restapi/handlers/vch_create.go
zjs
added a commit
to zjs/vic
that referenced
this pull request
Aug 30, 2018
…re#8239) * Support ID-based selection of host via create API Allow a stand-alone host (a host not in a cluster) to be referenced by ID during API-based VCH creation. * fixup! Support ID-based selection of host via create API (cherry picked from commit 67f248c) Conflicts: lib/apiservers/service/restapi/handlers/decode/references.go lib/apiservers/service/restapi/handlers/decode/references_test.go lib/apiservers/service/restapi/handlers/vch_create.go
zjs
added a commit
that referenced
this pull request
Aug 30, 2018
* Support ID-based selection of host via create API Allow a stand-alone host (a host not in a cluster) to be referenced by ID during API-based VCH creation. * fixup! Support ID-based selection of host via create API (cherry picked from commit 67f248c) Conflicts: lib/apiservers/service/restapi/handlers/decode/references.go lib/apiservers/service/restapi/handlers/decode/references_test.go lib/apiservers/service/restapi/handlers/vch_create.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow a stand-alone host (a host not in a cluster) to be referenced
by ID during API-based VCH creation.
Fixes #6711
[specific ci=Group23-VIC-Machine-Service]