Remove specifying nimbus location#8256
Merged
DanielXiao merged 1 commit intovmware:masterfrom Sep 6, 2018
Merged
Conversation
Remove nimbus location to get assigned location from nimbus. This fix deliverables of esx build 5050593 not found in wdc when run test 5-26-Static-IP-Address.
Contributor
Author
zjs
reviewed
Sep 5, 2018
| Create Simple VC Cluster With Static IP | ||
| [Arguments] ${name}=vic-simple-vc-static-ip | ||
| [Timeout] 110 minutes | ||
| Set Suite Variable ${NIMBUS_LOCATION} NIMBUS_LOCATION=wdc |
Member
There was a problem hiding this comment.
It seems like this is set in other places. Should those be updated as well for consistency?
Have we looked at the history of these files to determine if this was introduced for any specific reason?
Contributor
Author
There was a problem hiding this comment.
It is introduce in PR #7793 but I don't see why it is set to wdc.
Yes, I guess those should be updated.
Member
There was a problem hiding this comment.
It doesn't look like this PR was updated to cover those other places. Could you file a separate issue for that?
renmaosheng
approved these changes
Sep 6, 2018
renmaosheng
left a comment
renmaosheng
left a comment
There was a problem hiding this comment.
Please update the vic-product as well. thanks
yuyangbj
approved these changes
Sep 6, 2018
DanielXiao
added a commit
to DanielXiao/vic
that referenced
this pull request
Sep 6, 2018
Remove nimbus location to get assigned location from nimbus. This fix deliverables of esx build 5050593 not found in wdc when run test 5-26-Static-IP-Address. (cherry picked from commit 97845e6)
DanielXiao
added a commit
that referenced
this pull request
Sep 11, 2018
Remove nimbus location to get assigned location from nimbus. This fix deliverables of esx build 5050593 not found in wdc when run test 5-26-Static-IP-Address. (cherry picked from commit 97845e6)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove nimbus location to get assigned location from nimbus.
This fix deliverables of esx build 5050593 not found in wdc
when run test 5-26-Static-IP-Address.
Fixes #