Merged
Conversation
In VC 7.0, datastore path changes, so we need to add a new condition.
YanzhaoLi
reviewed
Feb 5, 2020
| } | ||
|
|
||
| if len(children) == 1 { // when image store path is given, we need to delete VIC dir too when it is empty. | ||
| if len(children) == 1 || len(children) == 0 { // when image store path is given, we need to delete VIC dir too when it is empty. |
Contributor
There was a problem hiding this comment.
Not familiar with these code. Which case is || len(children) == 0 for ?
Contributor
There was a problem hiding this comment.
i think it is empty dir
So in vc7.0, len(children) == 0 or 1 means empty dir, while in vc6.x only len(children) == 1 means empty dir
yuyangbj
approved these changes
Feb 5, 2020
YanzhaoLi
approved these changes
Feb 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In VC 7.0, datastore path changes, so we need to
add a new condition.
[specific ci=Group1-Docker-Commands]
Fixes #8613