New package: gammastep-2.0.2.#23643
Closed
CameronNemo wants to merge 1 commit intovoid-linux:masterfrom
Closed
Conversation
016533e to
b214fbe
Compare
Member
|
Would you say this closes #9909 ? |
Contributor
Author
|
yeah |
ericonr
pushed a commit
to ericonr/void-packages
that referenced
this pull request
Aug 30, 2020
Closes: void-linux#23643 [via git-merge-pr]
6c9c37b to
7f5f1c1
Compare
Member
|
Ping me next Monday if this is neither complaint nor merged. |
Contributor
Author
|
Bump! |
Contributor
Author
|
@sgn, any chance of merging? |
sgn
reviewed
Sep 22, 2020
| maintainer="Cameron Nemo <cnemo@tutanota.com>" | ||
| license="GPL-3.0-or-later" | ||
| homepage="https://gitlab.com/chinstrap/gammastep" | ||
| changelog="${homepage}/raw/master/NEWS.md" |
| version=2.0.2 | ||
| revision=1 | ||
| _ref="v${version}" | ||
| wrksrc="${pkgname}-${_ref}" |
Member
There was a problem hiding this comment.
Better to use v$version directly, I think
Comment on lines
+8
to
+15
| configure_args=" | ||
| --enable-gui --enable-drm --enable-vidmode --enable-randr --enable-wayland | ||
| --enable-apparmor --with-systemdunitdir=no $(vopt_enable geoclue2)" | ||
| hostmakedepends=" | ||
| tar automake libtool gettext-devel intltool pkg-config python3-devel | ||
| wayland-devel" | ||
| makedepends=" | ||
| wayland-devel libXxf86vm-devel libdrm-devel $(vopt_if geoclue2 'glib-devel')" |
Member
There was a problem hiding this comment.
This line break isn't consistent with other template :)
Member
|
Sorry, I forgot to press the submit review button. After all my comments addressed, I'll merge. |
Member
|
Sorry, my bad |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.