Skip to content

Conversation

@klarasm
Copy link
Contributor

@klarasm klarasm commented Mar 9, 2023

Testing the changes

  • I tested the changes in this PR: most of the test suite passes (excepting tgraphql), I don't use this package directly

This package has some weirdness in the test suite. It fails when run from ./xbps-src -K pkg virtuoso but succeeds if I do ./xbps-src chroot afterwards and:

make clean
./autogen.sh
./configure
make
make check

I tried replacing pre_configure, do_configure, do_build and do_check to do the same thing but it still fails. Maybe I'm missing some dependencies or something.

tgraphql is the only test failing:
tgraphql.output.log

Local build testing

  • I built this PR locally for my native architecture, (x86_64-glibc)
  • I built this PR locally for my native architecture, (x86_64-musl)

@klarasm klarasm mentioned this pull request Mar 9, 2023
6 tasks
@klarasm
Copy link
Contributor Author

klarasm commented Mar 9, 2023

I disabled tgraphql test for now. As I don't use this package directly I don't know if the resulting package works correctly.

@klarasm
Copy link
Contributor Author

klarasm commented Mar 9, 2023

Seems like thttp is failing on musl as well but the error does not appear on my x86_64-musl machine.

@klarasm
Copy link
Contributor Author

klarasm commented Mar 9, 2023

The thttp failure does not seem to be consistent. If anyone that uses virtuoso could test the changes I would appreciate it.

@klarasm klarasm marked this pull request as ready for review March 9, 2023 22:07
@github-actions
Copy link

github-actions bot commented Jun 8, 2023

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Jun 8, 2023
@klarasm
Copy link
Contributor Author

klarasm commented Jun 8, 2023

Bump. If there's any active user of this package that can test, I would appreciate it. 7.2.10 is released, will update PR to that.

@github-actions github-actions bot removed the Stale label Jun 9, 2023
@klarasm klarasm force-pushed the virtuoso-update branch from b6eb9b3 to c0d8683 Compare June 9, 2023 14:24
@klarasm klarasm changed the title virtuoso: update to 7.2.9 virtuoso: update to 7.2.10 Jun 19, 2023
@classabbyamp classabbyamp added the needs-testing Testing a PR or reproducing an issue needed label Jun 24, 2023
test suite was failing on revbump

- remove patches that no longer apply
- disable static libraries as we're removing them after install anyway
- disable tgraphql test (fails inside ./xbps-src)
- add which to hostmakedepends
- add missing checkdepends
- update project homepage
@Duncaen Duncaen merged commit 1d679c5 into void-linux:master Jun 25, 2023
@klarasm klarasm deleted the virtuoso-update branch June 28, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-testing Testing a PR or reproducing an issue needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants