fix(upgrade): bypass package manager release age gates during vp upgrade#1272
Merged
fengmk2 merged 4 commits intovoidzero-dev:mainfrom Apr 3, 2026
Merged
fix(upgrade): bypass package manager release age gates during vp upgrade#1272fengmk2 merged 4 commits intovoidzero-dev:mainfrom
vp upgrade#1272fengmk2 merged 4 commits intovoidzero-dev:mainfrom
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
Member
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a90dad89b1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
fengmk2
reviewed
Apr 2, 2026
fengmk2
reviewed
Apr 2, 2026
Collaborator
Author
|
@fengmk2 |
fengmk2
approved these changes
Apr 3, 2026
fengmk2
pushed a commit
that referenced
this pull request
Apr 8, 2026
## Summary related issues and PRs - #1260 - #1272 - #833 - #834 This updates the release-age handling for the Vite+ global install/upgrade path so we no longer silently bypass package manager protections. Users who configure pnpm `minimumReleaseAge` are explicitly trying to reduce supply-chain risk from newly published compromised packages. Instead of always writing `minimum-release-age=0`, Vite+ now first runs the wrapper install normally. If pnpm blocks the install with a release-age error, Vite+ only writes the local override and retries after an interactive, default-No confirmation. The same behavior is applied to the standalone install scripts, including `install.ps1` and `install.sh`. ## Changes - Remove unconditional `minimum-release-age=0` override from `vp upgrade` and standalone installers. - Detect pnpm release-age failures from `ERR_PNPM_NO_MATURE_MATCHING_VERSION`, `minimumReleaseAge` messages, and guarded `ERR_PNPM_NO_MATCHING_VERSION` cases. - Prompt users with a default-No warning before disabling release-age protection for this Vite+ install only. - Keep non-interactive environments blocked instead of adding a bypass flag or env var. - Preserve `install.log` / `upgrade.log` visibility for failure diagnosis. - Avoid passing `--silent` to the inner captured `vp install`, because pnpm suppresses the release-age error body in silent mode. - Add comments with pnpm source references explaining the release-age detection signals.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolves #1260
vp upgradefails when a package manager's global config enforces a minimum release age (e.g. pnpm'sminimumReleaseAge), because newly published vite-plus versions are blocked during dependency installation.Changes
vp install, bypassing release age gates for all package managers:.npmrc— pnpm (minimum-release-age=0) and npm (min-release-age=0).yarnrc.yml— yarn (npmMinimalAgeGate: "0m")bunfig.toml— bun (minimumReleaseAge = 0)upgrade.logon install failure with stdout+stderr for debugging