feat(editor): add npm.scriptRunner to VS Code settings#1346
feat(editor): add npm.scriptRunner to VS Code settings#1346jong-kyung wants to merge 6 commits intovoidzero-dev:mainfrom
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
|
@jong-kyung https://github.com/microsoft/vscode/blob/main/extensions/npm/package.json#L260 Do we need to add a |
Yes, I think you are right. Since vp is not currently in the allowed enum values for npm.scriptRunner, it definitely needs to be added. I will go ahead and open a PR to microsoft/vscode to add vp first, and I'll let you know here once it's created. |
|
I like the goal here, especially for
My main concern is the repo-level impact: once this lands in So I’d be comfortable with this in |
Thanks for the detailed feedback! That makes sense. I'll update this PR so that |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 637d0e9192
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f945d8f6b0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
f945d8f to
59cb6dc
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 59cb6dc750
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
I've also opened an upstream PR to add |
|
@jong-kyung Even if microsoft/vscode#308794 is not merged, it shouldn't prevent this configuration from taking effect, right? |
Yes, that's correct. It will still work without any issues even if the upstream PR isn't merged. The only side effect is a schema validation warning in |
Summary
"npm.scriptRunner": "vp"to theVSCODE_SETTINGSconstant so that VS Code's NPM Scripts panel runs scripts throughvptask runnerCloses #1337