refactor: extract check command into its own module#1350
refactor: extract check command into its own module#1350fengmk2 wants to merge 2 commits intowindows-installerfrom
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label auto-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
@codex review |
|
Codex Review: Didn't find any major issues. Another round soon, please! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
7bb82d7 to
2b0a367
Compare
2b0a367 to
2e2720b
Compare
5ad7900 to
e9cf38e
Compare
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit e9cf38e. Configure here.
d49974c to
1d5ca4a
Compare
e9cf38e to
7b8da63
Compare
Move the check command's orchestration logic, output analysis types, and parsing functions from cli.rs into a dedicated check/ directory, following the same pattern as exec/. cli.rs: 1,778 → 1,314 lines check/mod.rs: execute_check() orchestration (247 lines) check/analysis.rs: types, parsers, formatters (255 lines)
7b8da63 to
fd25de3
Compare
1d5ca4a to
9bb496d
Compare

Move the check command's orchestration logic, output analysis types,
and parsing functions from cli.rs into a dedicated check/ directory,
following the same pattern as exec/.
cli.rs: 1,778 → 1,314 lines
check/mod.rs: execute_check() orchestration (247 lines)
check/analysis.rs: types, parsers, formatters (255 lines)
Note
Medium Risk
Primarily a refactor, but it changes how
vp checkis dispatched and how fmt/lint output is captured/parsed, which could affect exit codes or CI output stability.Overview
Refactors the
vp checkimplementation by extracting its orchestration and output-parsing logic fromcli.rsinto a newcheck/module (check/mod.rs+check/analysis.rs), keeping the same fmt→lint flow and--fixre-format pass.Updates
cli.rsvisibility to reuseresolve_universal_vite_configandresolve_and_capture_output, and switches theChecksubcommand handler to delegate tocrate::check::execute_check; relatedLintMessageKindtests move with the extraction. Documentation inrfcs/check-command.mdis updated to reflect the new module layout and cache-input helper naming.Reviewed by Cursor Bugbot for commit e9cf38e. Configure here.