Skip to content

fix: resolve binary paths using which crate#295

Merged
fengmk2 merged 1 commit intomainfrom
11-10-fix_run_command_support_windows
Nov 10, 2025
Merged

fix: resolve binary paths using which crate#295
fengmk2 merged 1 commit intomainfrom
11-10-fix_run_command_support_windows

Conversation

@fengmk2
Copy link
Copy Markdown
Member

@fengmk2 fengmk2 commented Nov 10, 2025

Improved command execution by resolving binary paths with the which crate and enhanced error handling for missing executables.

https://doc.rust-lang.org/std/process/struct.Command.html#platform-specific-behavior

Copy link
Copy Markdown
Member Author

fengmk2 commented Nov 10, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@fengmk2 fengmk2 force-pushed the 11-10-fix_run_command_support_windows branch 2 times, most recently from 45dc813 to 3eeb58a Compare November 10, 2025 11:30
@fengmk2 fengmk2 force-pushed the 11-10-fix_run_command_support_windows branch from 3eeb58a to 290f4ac Compare November 10, 2025 11:39
@fengmk2 fengmk2 self-assigned this Nov 10, 2025
@fengmk2 fengmk2 changed the title fix: run_command support Windows feat(install): resolve binary paths using which crate Nov 10, 2025
@fengmk2 fengmk2 changed the title feat(install): resolve binary paths using which crate fix: resolve binary paths using which crate Nov 10, 2025
@fengmk2 fengmk2 marked this pull request as ready for review November 10, 2025 11:55
@fengmk2 fengmk2 requested review from Brooooooklyn, branchseer and Copilot and removed request for Copilot November 10, 2025 11:55
@fengmk2 fengmk2 merged commit 8931b8b into main Nov 10, 2025
17 checks passed
Copy link
Copy Markdown
Member Author

fengmk2 commented Nov 10, 2025

Merge activity

@fengmk2 fengmk2 deleted the 11-10-fix_run_command_support_windows branch November 10, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants