fix(Callback): guard UnitName() calls against secret string values in UNIT_SPELLCAST_SENT#49
Open
rcaril wants to merge 1 commit intovoidzone:mainfrom
Open
Conversation
… UNIT_SPELLCAST_SENT In PvP contexts (arenas, BGs), UnitName() can return a secret/protected string value. Comparing these against regular strings causes a Lua error: attempt to compare a secret string value (tainted by 'Gnosis'). The existing issecretvalue() guard only checked the event arguments (unit, target), not the return values of subsequent UnitName() calls. Store each UnitName() result and check issecretvalue() before comparing, covering both the rangeCheckTarget block (unit == player) and the class-detection block. Fixes errors when casting spells at focus/targettarget units with PvP-protected names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes LUA errors calling during the
UNIT_SPELLCAST_SENTevent due to callingUnitName()without checking if the value is protected. We check for various common scenarios - if any call would be a protected value,nilis returned to fail gracefully and avoid a LUA error.Validation:
I tested this fix in game and can confirm LUA errors are no longer thrown for any scenario.