test: fail TestAgentRuntimeSessionTTL on missing session ID#319
test: fail TestAgentRuntimeSessionTTL on missing session ID#319madmecodes wants to merge 1 commit into
Conversation
…session ID Signed-off-by: madmecodes <ayushguptadev1@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Code Review
This pull request modifies the TestAgentRuntimeSessionTTL end-to-end test to capture the response from the agent runtime invocation. It replaces a test skip with a fatal failure when a session ID is not returned, ensuring that missing session IDs are treated as errors and providing the response body for easier troubleshooting. I have no feedback to provide.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #319 +/- ##
==========================================
+ Coverage 47.57% 47.74% +0.17%
==========================================
Files 30 30
Lines 2819 2855 +36
==========================================
+ Hits 1341 1363 +22
- Misses 1338 1344 +6
- Partials 140 148 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR strengthens the AgentCube E2E suite by ensuring TestAgentRuntimeSessionTTL does not silently skip when the Router invocation response fails to include a session ID, which is required to actually exercise session TTL behavior.
Changes:
- Capture the full invocation response in
TestAgentRuntimeSessionTTL. - Replace
t.Skipwitht.Fatalfwhen the session ID is missing, including the response payload for debugging.
Summary
TestAgentRuntimeSessionTTLwas silently skipping viat.Skipwhen the invocation response lacked a session ID, letting CI pass green without actually testing TTL behavior.t.Skipwitht.Fatalfthat logs the full invocation response so the root cause is immediately visible.Fixes #198
Test plan