Skip to content

test: fail TestAgentRuntimeSessionTTL on missing session ID#319

Open
madmecodes wants to merge 1 commit into
volcano-sh:mainfrom
madmecodes:fix/session-ttl-test-skip
Open

test: fail TestAgentRuntimeSessionTTL on missing session ID#319
madmecodes wants to merge 1 commit into
volcano-sh:mainfrom
madmecodes:fix/session-ttl-test-skip

Conversation

@madmecodes
Copy link
Copy Markdown
Contributor

Summary

  • TestAgentRuntimeSessionTTL was silently skipping via t.Skip when the invocation response lacked a session ID, letting CI pass green without actually testing TTL behavior.
  • Replaced the t.Skip with t.Fatalf that logs the full invocation response so the root cause is immediately visible.

Fixes #198

Test plan

  • The test will now fail loudly if the runtime does not return a session ID, surfacing TTL regressions instead of hiding them.
  • When a session ID is returned, behavior is unchanged -- TTL expiration is exercised as before.

…session ID

Signed-off-by: madmecodes <ayushguptadev1@gmail.com>
Copilot AI review requested due to automatic review settings May 11, 2026 14:09
@volcano-sh-bot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign yaozengzeng for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies the TestAgentRuntimeSessionTTL end-to-end test to capture the response from the agent runtime invocation. It replaces a test skip with a fatal failure when a session ID is not returned, ensuring that missing session IDs are treated as errors and providing the response body for easier troubleshooting. I have no feedback to provide.

@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.74%. Comparing base (524e55e) to head (ae650d4).
⚠️ Report is 41 commits behind head on main.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #319      +/-   ##
==========================================
+ Coverage   47.57%   47.74%   +0.17%     
==========================================
  Files          30       30              
  Lines        2819     2855      +36     
==========================================
+ Hits         1341     1363      +22     
- Misses       1338     1344       +6     
- Partials      140      148       +8     
Flag Coverage Δ
unittests 47.74% <ø> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR strengthens the AgentCube E2E suite by ensuring TestAgentRuntimeSessionTTL does not silently skip when the Router invocation response fails to include a session ID, which is required to actually exercise session TTL behavior.

Changes:

  • Capture the full invocation response in TestAgentRuntimeSessionTTL.
  • Replace t.Skip with t.Fatalf when the session ID is missing, including the response payload for debugging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

4 participants