add PodGroup dashboard support #184

vzhou-p · 2025-12-22T23:56:07Z

add PodGroup dashboard support

Add backend API endpoints for PodGroups (list, details, YAML)
Add frontend route and navigation for PodGroups
Create PodGroup list view with filtering and sorting
Add PodGroup details dialog
Update tests

volcano-sh-bot · 2025-12-22T23:56:20Z

Welcome @vzhou-p! It looks like this is your first PR to volcano-sh/dashboard 🎉

gemini-code-assist · 2025-12-22T23:56:29Z

Summary of Changes

Hello @vzhou-p, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the dashboard's capabilities by integrating full support for Kubernetes PodGroups. It provides users with a dedicated section to monitor and manage their PodGroups, offering a clear overview through a sortable and filterable list, and the ability to inspect detailed YAML configurations. This feature improves visibility and control over PodGroup resources within the application.

Highlights

PodGroup API Endpoints: New backend API endpoints have been added to support listing, retrieving details, and fetching YAML for PodGroups.
Frontend Integration: A new frontend route and navigation item for PodGroups have been introduced, making them accessible in the dashboard.
PodGroup List View: A dedicated list view for PodGroups has been implemented, featuring filtering by namespace and status, and sorting by creation time.
PodGroup Details Dialog: A dialog component has been added to display the detailed YAML configuration of a selected PodGroup.
Test Coverage: Backend and frontend tests have been updated to reflect the new PodGroup functionality and API changes.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request adds dashboard support for PodGroups, including backend API endpoints and a full frontend implementation with list and detail views. The changes are well-structured and reuse existing components effectively. I've identified a potential Cross-Site Scripting (XSS) vulnerability in how YAML is displayed, which should be addressed. I've also left a couple of minor suggestions to remove debug logging and improve the UI feedback during data loading.

gemini-code-assist · 2025-12-22T23:58:02Z

frontend/src/components/podgroups/PodGroupDialog.jsx

+                    <pre
+                        dangerouslySetInnerHTML={{
+                            __html: selectedYaml,
+                        }}
+                    />


Using dangerouslySetInnerHTML with data that originates from an external source (the Kubernetes API in this case) can introduce a Cross-Site Scripting (XSS) vulnerability. The YAML content, especially keys and values, is being wrapped in HTML without proper escaping in frontend/src/components/podgroups/PodGroups.jsx. If a PodGroup name or another value in its YAML contains malicious HTML, it will be executed by the browser.

To fix this, you should either use a dedicated syntax highlighting library that handles sanitization safely (like react-syntax-highlighter), or ensure all content is properly HTML-escaped before being passed to dangerouslySetInnerHTML. The logic for formatting the YAML is in PodGroups.jsx inside the handleClick function and should be updated to escape HTML characters.

Fixed. I've updated the YAML formatting logic in PodGroups.jsx to use lodash.escape on both the keys and values before constructing the HTML string. This ensures that any user-supplied content is sanitized while still allowing us to wrap the keys in our custom tags for highlighting. The PodGroupDialog then safely renders this pre-sanitized string.

gemini-code-assist · 2025-12-22T23:58:02Z

backend/src/server.js

+        console.log("Fetching podgroups with params:", {
+            namespace,
+            searchTerm,
+            statusFilter,
+        });


This console.log statement appears to be for debugging purposes. It's best to remove such logs from production code to avoid cluttering the logs and potentially leaking sensitive information.

frontend/src/components/podgroups/PodGroups.jsx

- Add backend API endpoints for PodGroups (list, details, YAML) - Add frontend route and navigation for PodGroups - Create PodGroup list view with filtering and sorting - Add PodGroup details dialog - Update tests Signed-off-by: Victor Zhou <binghua.zhou.ca@gmail.com>

JesseStutler · 2025-12-31T01:43:56Z

@vzhou-p There are some CI failures, could you take a look?

mtian29

Thanks @vzhou-p

volcano-sh-bot · 2026-01-05T22:46:06Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mtian29
Once this PR has been reviewed and has the lgtm label, please assign william-wang for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

JesseStutler · 2026-01-06T06:33:58Z

@vzhou-p Seems that still have some lint erorrs, please take a look

volcano-sh-bot requested review from kevin-wangzefeng and wangyang0616 December 22, 2025 23:56

volcano-sh-bot added the size/XXL label Dec 22, 2025

gemini-code-assist bot reviewed Dec 22, 2025

View reviewed changes

vzhou-p force-pushed the feature/pod-group branch 3 times, most recently from 1f97fdc to c24675b Compare December 23, 2025 02:21

vzhou-p force-pushed the feature/pod-group branch from c24675b to cdec418 Compare December 23, 2025 02:25

volcano-sh-bot assigned JesseStutler Dec 31, 2025

volcano-sh-bot added the lgtm label Dec 31, 2025

JesseStutler removed the lgtm label Dec 31, 2025

fix dependency and reformat

f9262c3

mtian29 approved these changes Jan 5, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

add PodGroup dashboard support #184

add PodGroup dashboard support #184

Uh oh!

vzhou-p commented Dec 22, 2025

Uh oh!

volcano-sh-bot commented Dec 22, 2025

Uh oh!

gemini-code-assist bot commented Dec 22, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Dec 22, 2025

Uh oh!

vzhou-p Dec 23, 2025

Uh oh!

gemini-code-assist bot Dec 22, 2025

Uh oh!

Uh oh!

JesseStutler commented Dec 31, 2025

Uh oh!

mtian29 left a comment

Uh oh!

volcano-sh-bot commented Jan 5, 2026

Uh oh!

JesseStutler commented Jan 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

add PodGroup dashboard support #184

Are you sure you want to change the base?

add PodGroup dashboard support #184

Uh oh!

Conversation

vzhou-p commented Dec 22, 2025

Uh oh!

volcano-sh-bot commented Dec 22, 2025

Uh oh!

gemini-code-assist bot commented Dec 22, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

vzhou-p Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

JesseStutler commented Dec 31, 2025

Uh oh!

mtian29 left a comment

Choose a reason for hiding this comment

Uh oh!

volcano-sh-bot commented Jan 5, 2026

Uh oh!

JesseStutler commented Jan 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants