feat: add oc2ov auto test improvements

[kaisongli]

• Session ID 自动管理
• 智能等待策略
• 重试机制
• 测试数据管理

Description

Related Issue

Type of Change

• Bug fix (non-breaking change that fixes an issue)
• New feature (non-breaking change that adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update
• Refactoring (no functional changes)
• Performance improvement
• Test update

Changes Made

Testing

• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• I have tested this on the following platforms:
  • Linux
  • macOS
  • Windows

Checklist

• My code follows the project's coding style
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• Any dependent changes have been merged and published

Screenshots (if applicable)

Additional Notes

[github-actions]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 4 🔵🔵🔵🔵⚪

🏅 Score: 72

🧪 PR contains tests

🔒 No security concerns identified

✅ No TODO sections

🔀 Multiple PR themes Sub-PR theme: Add test utilities (session, wait, retry, data management) Relevant files: tests/oc2ov_test/utils/test_utils.py tests/oc2ov_test/tests/base_cli_test.py Sub-PR theme: Update existing tests to use new utilities Relevant files: tests/oc2ov_test/tests/p0/test_memory_crud.py tests/oc2ov_test/tests/p0/test_memory_write.py tests/oc2ov_test/tests/skill/test_skill_memory.py tests/oc2ov_test/tests/long_term/test_long_term_conversation.py tests/oc2ov_test/tests/session/test_session_persistence.py tests/oc2ov_test/tests/advanced/test_advanced_scenarios.py tests/oc2ov_test/conftest.py Sub-PR theme: Add enhanced features demonstration tests Relevant files: tests/oc2ov_test/tests/advanced/test_enhanced_features.py

⚡ Recommended focus areas for review Session ID Mismatch in Smart Wait smart_wait_for_sync hardcodes self.current_session_id when checking the response, which fails for tests using custom session IDs. This leads to checking the wrong session's state, causing flaky or incorrect test results. def smart_wait_for_sync( self, check_message: str = None, keywords: list = None, timeout: float = None, poll_interval: float = 2.0, ) -> bool: """ 智能等待记忆同步（轮询检查） Args: check_message: 用于检查的消息（如不提供则使用固定等待） keywords: 期望响应中包含的关键词 timeout: 超时时间（秒） poll_interval: 轮询间隔（秒） Returns: bool: 是否成功同步 """ if not check_message or not keywords: self.wait_for_sync() return True timeout = timeout or self.wait_time * 3 def check_response() -> bool: response = self.client.send_message(check_message, session_id=self.current_session_id) return self.assertion.assert_keywords_in_response( response, keywords, require_all=True, case_sensitive=False ) return self.smart_waiter.wait_for_condition( check_response, timeout=timeout, poll_interval=poll_interval, message=f"等待记忆同步 (关键词: {keywords})", ) Test Isolation Risk session_manager and data_manager are class-level attributes, shared across all test instances. This can cause state leakage between tests (e.g., custom test data registered in one test affects others). session_manager: SessionIdManager = SessionIdManager() data_manager: TestDataManager = get_default_data_manager() Unused Import Risk SmartWaiter.wait_for_response_keywords imports AssertionHelper from utils.assertions, but this method is not used in the PR. If utils.assertions is not available in all import contexts, this could cause import errors. def wait_for_response_keywords( self, get_response: Callable[[], Dict[str, Any]], keywords: List[str], timeout: Optional[float] = None, poll_interval: Optional[float] = None, require_all: bool = True, case_sensitive: bool = False, ) -> bool: """ 等待响应中包含指定关键词 Args: get_response: 获取响应的函数 keywords: 关键词列表 timeout: 超时时间（秒） poll_interval: 轮询间隔（秒） require_all: 是否要求所有关键词都出现 case_sensitive: 是否区分大小写 Returns: bool: 是否在超时前找到关键词 """ from utils.assertions import AssertionHelper def check_keywords() -> bool: response = get_response() return AssertionHelper.assert_keywords_in_response( response, keywords, require_all, case_sensitive ) return self.wait_for_condition( check_keywords, timeout=timeout, poll_interval=poll_interval, message=f"等待响应包含关键词: {keywords}", ) Docstring-Code Inconsistency SmartWaiter.smart_wait claims to use historical response times for adaptive waiting, but the code only uses a fixed 1.2x multiplier without any history tracking. def smart_wait( self, base_wait: float = 5.0, max_wait: float = 30.0, adaptive: bool = True, ) -> float: """ 智能等待，根据历史响应时间调整等待时间 Args: base_wait: 基础等待时间（秒） max_wait: 最大等待时间（秒） adaptive: 是否自适应调整 Returns: float: 实际等待时间 """ wait_time = base_wait if adaptive: wait_time = min(wait_time * 1.2, max_wait) logger.info(f"智能等待 {wait_time:.1f} 秒...") time.sleep(wait_time) return wait_time

[github-actions]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
Possible issue	Add session_id support to smart_wait_for_sync Add a session_id parameter to smart_wait_for_sync to support custom sessions. This fixes a critical bug where the method always used the class-level session instead of the custom session passed to send_and_log. tests/oc2ov_test/tests/base_cli_test.py [108-137] def smart_wait_for_sync( self, check_message: str = None, keywords: list = None, timeout: float = None, poll_interval: float = 2.0, + session_id: str = None, ) -> bool: """ 智能等待记忆同步（轮询检查） Args: check_message: 用于检查的消息（如不提供则使用固定等待） keywords: 期望响应中包含的关键词 timeout: 超时时间（秒） poll_interval: 轮询间隔（秒） + session_id: session ID（默认使用当前测试类的 session_id） Returns: bool: 是否成功同步 """ if not check_message or not keywords: self.wait_for_sync() return True timeout = timeout or self.wait_time * 3 + target_session_id = session_id or self.current_session_id def check_response() -> bool: - response = self.client.send_message(check_message, session_id=self.current_session_id) + response = self.client.send_message(check_message, session_id=target_session_id) return self.assertion.assert_keywords_in_response( response, keywords, require_all=True, case_sensitive=False ) Suggestion importance[1-10]: 8 __ Why: Adds a session_id parameter to smart_wait_for_sync to support custom sessions, fixing a bug where the method always used the class-level session. This improves test reliability when using custom session IDs.	Medium