Skip to content

fix: sanitize internal error details in bot proxy responses #1310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qin-ctx merged 1 commit into from
Apr 9, 2026
Merged

fix: sanitize internal error details in bot proxy responses #1310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions openviking/server/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,14 +186,14 @@ async def openviking_error_handler(request: Request, exc: OpenVikingError):
# Catch-all for unhandled exceptions so clients always get JSON
@app.exception_handler(Exception)
async def general_error_handler(request: Request, exc: Exception):
logger.warning("Unhandled exception: %s", exc)
logger.exception("Unhandled exception")
return JSONResponse(
status_code=500,
content=Response(
status="error",
error=ErrorInfo(
code="INTERNAL",
message=str(exc),
message="Internal server error",
),
).model_dump(),
)
Expand Down
1 change: 0 additions & 1 deletion openviking/server/routers/bot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ async def health_check(request: Request):

try:
async with httpx.AsyncClient() as client:
print(f"url={f'{bot_url}/bot/v1/health'}")
# Forward to Vikingbot OpenAPIChannel health endpoint
response = await client.get(
f"{bot_url}/bot/v1/health",
Expand Down