fix(storage): handle append_file missing-path errors as not_found#1383
Closed
Gujiassh wants to merge 1 commit intovolcengine:mainfrom
Closed
fix(storage): handle append_file missing-path errors as not_found#1383Gujiassh wants to merge 1 commit intovolcengine:mainfrom
Gujiassh wants to merge 1 commit intovolcengine:mainfrom
Conversation
|
Failed to generate code suggestions for PR |
Collaborator
|
This issue was fixed by #1348 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:\n- handle append failures caused by missing target files as not_found instead of generic errors\n- preserve existing behavior for successful append and non-missing failure modes\n- add regression coverage for append-to-missing-file behavior in the storage layer\n\nTesting:\n- pytest tests/misc/test_append_file_missing.py -q (blocked: tests/conftest.py imports openviking package requiring bundled AGFS client build)\n- python3 -m compileall openviking/storage/viking_fs.py tests/misc/test_append_file_missing.py\n\nLocal test constraint:\n- editable install is blocked in this environment by Rust/Cargo toolchain (edition2024 unsupported in Cargo 1.75.0).