Minor simplification of the serde dependency#4866
Conversation
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
75bd276 to
4c91e79
Compare
a10y
left a comment
There was a problem hiding this comment.
does this actually affect code size or compile times? vs just importing serde without the derive feature
|
seems like the answer is yes, because it decouples the compilation units - BurntSushi/rust-csv#403 (comment) |
|
Nice, yea I was a bit confused by the crate doc
But then it goes on to mention that it allows to parallelize the serde-derive build, so I guess for a downstream crate it will see benefits |
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Codecov Report❌ Patch coverage is
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vortex-arraydoesn't need serde at all IMO.vortex-buffersonly needsserde_core, so that should help a bit in some cases.