Skip to content

Remove some vortex mem allocations in "zero-copy" memory transformations#503

Merged
joseph-isaacs merged 2 commits intodevelopfrom
remove-some-vtx-array-mem-copies
Jul 23, 2024
Merged

Remove some vortex mem allocations in "zero-copy" memory transformations#503
joseph-isaacs merged 2 commits intodevelopfrom
remove-some-vtx-array-mem-copies

Conversation

@joseph-isaacs
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

@robert3005 robert3005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have some formatting issues

@joseph-isaacs joseph-isaacs merged commit a246864 into develop Jul 23, 2024
@joseph-isaacs joseph-isaacs deleted the remove-some-vtx-array-mem-copies branch July 23, 2024 11:45

pub fn boolean_buffer(&self) -> BooleanBuffer {
BooleanBuffer::new(
self.buffer().clone().into(),
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apache/arrow-rs#6033 strikes again

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you inspired me, #504

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants