Skip to content

Fix remaining copies #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
a10y merged 2 commits into from
Jul 23, 2024
Merged

Fix remaining copies #504

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb23e63
Fix remaining copies
a10y Jul 23, 2024
d41a7b3
revert cargo patches
a10y Jul 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions vortex-array/src/array/varbinview/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ use std::{mem, slice};

use ::serde::{Deserialize, Serialize};
use arrow_array::{ArrayRef, BinaryViewArray, StringViewArray};
use arrow_buffer::{Buffer, ScalarBuffer};
use arrow_buffer::ScalarBuffer;
use arrow_schema::DataType;
use itertools::Itertools;
use vortex_dtype::{DType, Nullability, PType};
Expand Down Expand Up @@ -271,18 +271,18 @@ fn as_arrow(var_bin_view: VarBinViewArray) -> ArrayRef {

let data = data
.iter()
.map(|p| Buffer::from(p.buffer()))
.map(|p| p.buffer().clone().into_arrow())
.collect::<Vec<_>>();

// Switch on Arrow DType.
match var_bin_view.dtype() {
DType::Binary(_) => Arc::new(BinaryViewArray::new(
ScalarBuffer::<u128>::from(Buffer::from(views.buffer())),
ScalarBuffer::<u128>::from(views.buffer().clone().into_arrow()),
data,
nulls,
)),
DType::Utf8(_) => Arc::new(StringViewArray::new(
ScalarBuffer::<u128>::from(Buffer::from(views.buffer())),
ScalarBuffer::<u128>::from(views.buffer().clone().into_arrow()),
data,
nulls,
)),
Expand Down