Skip to content

Conversation

@d33bs
Copy link
Contributor

@d33bs d33bs commented Dec 6, 2025

This PR adds the __version__ attribute to the Python package. This is commonly added to Python packages to help observe the version of a package through the package API. I tried to make this with dynamic versioning in mind, but please don't hesitate to provide feedback if this misses the mark.

Closes #5615

d33bs added 3 commits December 6, 2025 16:34
DCO Remediation Commit for d33bs <ekgto445@gmail.com>

I, d33bs <ekgto445@gmail.com>, hereby add my Signed-off-by to this commit: 4d9acd3

Signed-off-by: d33bs <ekgto445@gmail.com>
@codecov
Copy link

codecov bot commented Dec 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.46%. Comparing base (1174399) to head (713c1f0).
⚠️ Report is 3 commits behind head on develop.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@robert3005 robert3005 added the feature Release label indicating a new feature or request label Dec 7, 2025
@AdamGS
Copy link
Contributor

AdamGS commented Dec 9, 2025

This LGTM, do you want to fix the linter issue so we can merge it?

@d33bs
Copy link
Contributor Author

d33bs commented Dec 9, 2025

Thanks @AdamGS! Yes, I'll go ahead and fix the linting issue.

d33bs added 2 commits December 9, 2025 09:58
Signed-off-by: Dave Bunten <ekgto445@gmail.com>
…ttribute

DCO Remediation Commit for d33bs <ekgto445@gmail.com>

I, d33bs <ekgto445@gmail.com>, hereby add my Signed-off-by to this commit: 7030b9c

Signed-off-by: d33bs <ekgto445@gmail.com>
@d33bs d33bs force-pushed the python-version-attribute branch from ebd4d65 to 713c1f0 Compare December 9, 2025 19:48
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 9, 2025

CodSpeed Performance Report

Merging #5641 will degrade performances by 10.49%

Comparing d33bs:python-version-attribute (713c1f0) with develop (1174399)

Summary

❌ 2 regressions
✅ 1197 untouched
⏩ 624 skipped1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
take_map[(0.05, 1.0)] 3.6 ms 4 ms -10.49%
take_map[(0.1, 1.0)] 4.3 ms 4.8 ms -10.21%

Footnotes

  1. 624 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@AdamGS
Copy link
Contributor

AdamGS commented Dec 10, 2025

Thank you for your contribution!

@AdamGS AdamGS marked this pull request as ready for review December 10, 2025 09:28
@AdamGS AdamGS enabled auto-merge (squash) December 10, 2025 09:28
@AdamGS AdamGS merged commit e0833e2 into vortex-data:develop Dec 10, 2025
46 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Release label indicating a new feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vortex-python could benefit from a __version__ attribute for version references

3 participants